Conversation
6893c87 to
2ed7708
Compare
| <2> The `tolerationSeconds` field is optional. | ||
| + | ||
|
|
||
| * If the `key` field is set to `dns-only`, it can be tolerated indefinitely. |
There was a problem hiding this comment.
Can you check the numbering here? https://106087--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/networking_operators/dns-operator.html#nw-controlling-dns-pod-placement_dns-operator using (**) might resolve any potential issues?
stevsmit
left a comment
There was a problem hiding this comment.
Big takeaways: Generally we want to try to use "Specifies. . ." in call outs, though we can't always force it. In the case where we can't force it, we want to strive for parallelism. That comes from Andrea/Ingrid.
2d69776 to
d20f311
Compare
d20f311 to
e05d649
Compare
|
New changes are detected. LGTM label has been removed. |
e05d649 to
4a21e0f
Compare
|
@JoeAldinger: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick enterprise-4.22 |
|
@JoeAldinger: #106087 failed to apply on top of branch "enterprise-4.16": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@JoeAldinger: #106087 failed to apply on top of branch "enterprise-4.17": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@JoeAldinger: #106087 failed to apply on top of branch "enterprise-4.18": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@JoeAldinger: #106087 failed to apply on top of branch "enterprise-4.19": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@JoeAldinger: #106087 failed to apply on top of branch "enterprise-4.20": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@JoeAldinger: #106087 failed to apply on top of branch "enterprise-4.21": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@JoeAldinger: new pull request created: #106763 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
4.16+
Issue:
https://issues.redhat.com/browse/OSDOCS-16848
Link to docs preview:
QE review:
Additional information: