Skip to content

Comments

NOP-7#106087

Merged
JoeAldinger merged 1 commit intoopenshift:mainfrom
JoeAldinger:OSDOCS-16848-patch
Feb 17, 2026
Merged

NOP-7#106087
JoeAldinger merged 1 commit intoopenshift:mainfrom
JoeAldinger:OSDOCS-16848-patch

Conversation

@JoeAldinger
Copy link
Contributor

@JoeAldinger JoeAldinger commented Feb 5, 2026

Version(s):
4.16+

Issue:
https://issues.redhat.com/browse/OSDOCS-16848

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@stevsmit stevsmit added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Feb 11, 2026
<2> The `tolerationSeconds` field is optional.
+

* If the `key` field is set to `dns-only`, it can be tolerated indefinitely.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@stevsmit stevsmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big takeaways: Generally we want to try to use "Specifies. . ." in call outs, though we can't always force it. In the case where we can't force it, we want to strive for parallelism. That comes from Andrea/Ingrid.

@JoeAldinger JoeAldinger force-pushed the OSDOCS-16848-patch branch 6 times, most recently from 2d69776 to d20f311 Compare February 12, 2026 13:59
@stevsmit stevsmit added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2026
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2026
@openshift-ci
Copy link

openshift-ci bot commented Feb 12, 2026

New changes are detected. LGTM label has been removed.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 13, 2026
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 17, 2026
@openshift-ci
Copy link

openshift-ci bot commented Feb 17, 2026

@JoeAldinger: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@JoeAldinger JoeAldinger merged commit 6c48aa7 into openshift:main Feb 17, 2026
2 checks passed
@JoeAldinger
Copy link
Contributor Author

/cherrypick enterprise-4.22
/cherrypick enterprise-4.21
/cherrypick enterprise-4.20
/cherrypick enterprise-4.19
/cherrypick enterprise-4.18
/cherrypick enterprise-4.17
/cherrypick enterprise-4.16

@openshift-cherrypick-robot

@JoeAldinger: #106087 failed to apply on top of branch "enterprise-4.16":

Applying: NOP-7
Using index info to reconstruct a base tree...
M	modules/k8s-nmstate-installing-the-kubernetes-nmstate-operator.adoc
M	modules/k8s-nmstate-uninstall-operator.adoc
A	modules/nw-bpfman-infw-about.adoc
A	modules/nw-bpfman-infw-configure.adoc
M	modules/nw-controlling-dns-pod-placement.adoc
M	modules/nw-dns-cache-tuning.adoc
M	modules/nw-dns-forward.adoc
M	modules/nw-dns-view.adoc
M	modules/nw-infw-operator-config-object.adoc
M	modules/nw-infw-operator-cr.adoc
M	modules/nw-infw-operator-installing-cli.adoc
M	modules/nw-infw-operator-installing-console.adoc
A	modules/viewing-stats-collected-kubernetes-nmtate-op.adoc
M	networking/networking_operators/dns-operator.adoc
M	networking/networking_operators/ingress-node-firewall-operator.adoc
Falling back to patching base and 3-way merge...
Auto-merging networking/networking_operators/ingress-node-firewall-operator.adoc
Auto-merging networking/networking_operators/dns-operator.adoc
CONFLICT (modify/delete): modules/viewing-stats-collected-kubernetes-nmtate-op.adoc deleted in HEAD and modified in NOP-7. Version NOP-7 of modules/viewing-stats-collected-kubernetes-nmtate-op.adoc left in tree.
Auto-merging modules/nw-infw-operator-installing-console.adoc
Auto-merging modules/nw-infw-operator-installing-cli.adoc
Auto-merging modules/nw-infw-operator-cr.adoc
Auto-merging modules/nw-infw-operator-config-object.adoc
CONFLICT (content): Merge conflict in modules/nw-infw-operator-config-object.adoc
Auto-merging modules/nw-dns-view.adoc
Auto-merging modules/nw-dns-forward.adoc
CONFLICT (content): Merge conflict in modules/nw-dns-forward.adoc
Auto-merging modules/nw-dns-cache-tuning.adoc
CONFLICT (content): Merge conflict in modules/nw-dns-cache-tuning.adoc
Auto-merging modules/nw-controlling-dns-pod-placement.adoc
CONFLICT (content): Merge conflict in modules/nw-controlling-dns-pod-placement.adoc
CONFLICT (modify/delete): modules/nw-bpfman-infw-configure.adoc deleted in HEAD and modified in NOP-7. Version NOP-7 of modules/nw-bpfman-infw-configure.adoc left in tree.
CONFLICT (modify/delete): modules/nw-bpfman-infw-about.adoc deleted in HEAD and modified in NOP-7. Version NOP-7 of modules/nw-bpfman-infw-about.adoc left in tree.
Auto-merging modules/k8s-nmstate-uninstall-operator.adoc
CONFLICT (content): Merge conflict in modules/k8s-nmstate-uninstall-operator.adoc
Auto-merging modules/k8s-nmstate-installing-the-kubernetes-nmstate-operator.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 NOP-7

Details

In response to this:

/cherrypick enterprise-4.22
/cherrypick enterprise-4.21
/cherrypick enterprise-4.20
/cherrypick enterprise-4.19
/cherrypick enterprise-4.18
/cherrypick enterprise-4.17
/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@JoeAldinger: #106087 failed to apply on top of branch "enterprise-4.17":

Applying: NOP-7
Using index info to reconstruct a base tree...
M	modules/k8s-nmstate-deploying-nmstate-CLI.adoc
M	modules/k8s-nmstate-installing-the-kubernetes-nmstate-operator.adoc
M	modules/k8s-nmstate-uninstall-operator.adoc
M	modules/nw-controlling-dns-pod-placement.adoc
M	modules/nw-dns-cache-tuning.adoc
M	modules/nw-dns-forward.adoc
M	modules/nw-dns-view.adoc
M	modules/nw-infw-operator-config-object.adoc
M	modules/nw-infw-operator-cr.adoc
M	modules/nw-infw-operator-installing-cli.adoc
M	modules/nw-infw-operator-installing-console.adoc
M	modules/viewing-stats-collected-kubernetes-nmtate-op.adoc
M	networking/networking_operators/dns-operator.adoc
M	networking/networking_operators/ingress-node-firewall-operator.adoc
Falling back to patching base and 3-way merge...
Auto-merging networking/networking_operators/ingress-node-firewall-operator.adoc
Auto-merging networking/networking_operators/dns-operator.adoc
Auto-merging modules/viewing-stats-collected-kubernetes-nmtate-op.adoc
Auto-merging modules/nw-infw-operator-installing-console.adoc
Auto-merging modules/nw-infw-operator-installing-cli.adoc
Auto-merging modules/nw-infw-operator-cr.adoc
Auto-merging modules/nw-infw-operator-config-object.adoc
CONFLICT (content): Merge conflict in modules/nw-infw-operator-config-object.adoc
Auto-merging modules/nw-dns-view.adoc
Auto-merging modules/nw-dns-forward.adoc
CONFLICT (content): Merge conflict in modules/nw-dns-forward.adoc
Auto-merging modules/nw-dns-cache-tuning.adoc
CONFLICT (content): Merge conflict in modules/nw-dns-cache-tuning.adoc
Auto-merging modules/nw-controlling-dns-pod-placement.adoc
CONFLICT (content): Merge conflict in modules/nw-controlling-dns-pod-placement.adoc
Auto-merging modules/k8s-nmstate-uninstall-operator.adoc
CONFLICT (content): Merge conflict in modules/k8s-nmstate-uninstall-operator.adoc
Auto-merging modules/k8s-nmstate-installing-the-kubernetes-nmstate-operator.adoc
Auto-merging modules/k8s-nmstate-deploying-nmstate-CLI.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 NOP-7

Details

In response to this:

/cherrypick enterprise-4.22
/cherrypick enterprise-4.21
/cherrypick enterprise-4.20
/cherrypick enterprise-4.19
/cherrypick enterprise-4.18
/cherrypick enterprise-4.17
/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@JoeAldinger: #106087 failed to apply on top of branch "enterprise-4.18":

Applying: NOP-7
Using index info to reconstruct a base tree...
M	modules/k8s-nmstate-deploying-nmstate-CLI.adoc
M	modules/k8s-nmstate-installing-the-kubernetes-nmstate-operator.adoc
M	modules/k8s-nmstate-uninstall-operator.adoc
M	modules/nw-dns-cache-tuning.adoc
M	modules/nw-dns-forward.adoc
M	modules/nw-infw-operator-config-object.adoc
M	modules/nw-infw-operator-cr.adoc
M	modules/nw-infw-operator-installing-cli.adoc
M	modules/nw-infw-operator-installing-console.adoc
M	modules/viewing-stats-collected-kubernetes-nmtate-op.adoc
M	networking/networking_operators/dns-operator.adoc
M	networking/networking_operators/ingress-node-firewall-operator.adoc
Falling back to patching base and 3-way merge...
Auto-merging networking/networking_operators/ingress-node-firewall-operator.adoc
Auto-merging networking/networking_operators/dns-operator.adoc
Auto-merging modules/viewing-stats-collected-kubernetes-nmtate-op.adoc
Auto-merging modules/nw-infw-operator-installing-console.adoc
Auto-merging modules/nw-infw-operator-installing-cli.adoc
Auto-merging modules/nw-infw-operator-cr.adoc
Auto-merging modules/nw-infw-operator-config-object.adoc
CONFLICT (content): Merge conflict in modules/nw-infw-operator-config-object.adoc
Auto-merging modules/nw-dns-forward.adoc
CONFLICT (content): Merge conflict in modules/nw-dns-forward.adoc
Auto-merging modules/nw-dns-cache-tuning.adoc
CONFLICT (content): Merge conflict in modules/nw-dns-cache-tuning.adoc
Auto-merging modules/k8s-nmstate-uninstall-operator.adoc
CONFLICT (content): Merge conflict in modules/k8s-nmstate-uninstall-operator.adoc
Auto-merging modules/k8s-nmstate-installing-the-kubernetes-nmstate-operator.adoc
Auto-merging modules/k8s-nmstate-deploying-nmstate-CLI.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 NOP-7

Details

In response to this:

/cherrypick enterprise-4.22
/cherrypick enterprise-4.21
/cherrypick enterprise-4.20
/cherrypick enterprise-4.19
/cherrypick enterprise-4.18
/cherrypick enterprise-4.17
/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@JoeAldinger: #106087 failed to apply on top of branch "enterprise-4.19":

Applying: NOP-7
Using index info to reconstruct a base tree...
M	modules/k8s-nmstate-installing-the-kubernetes-nmstate-operator.adoc
M	modules/k8s-nmstate-uninstall-operator.adoc
M	modules/nw-dns-cache-tuning.adoc
M	modules/nw-dns-forward.adoc
M	modules/nw-dns-view.adoc
M	modules/nw-infw-operator-installing-console.adoc
M	modules/viewing-stats-collected-kubernetes-nmtate-op.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/viewing-stats-collected-kubernetes-nmtate-op.adoc
Auto-merging modules/nw-infw-operator-installing-console.adoc
Auto-merging modules/nw-dns-view.adoc
Auto-merging modules/nw-dns-forward.adoc
Auto-merging modules/nw-dns-cache-tuning.adoc
CONFLICT (content): Merge conflict in modules/nw-dns-cache-tuning.adoc
Auto-merging modules/k8s-nmstate-uninstall-operator.adoc
Auto-merging modules/k8s-nmstate-installing-the-kubernetes-nmstate-operator.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 NOP-7

Details

In response to this:

/cherrypick enterprise-4.22
/cherrypick enterprise-4.21
/cherrypick enterprise-4.20
/cherrypick enterprise-4.19
/cherrypick enterprise-4.18
/cherrypick enterprise-4.17
/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@JoeAldinger: #106087 failed to apply on top of branch "enterprise-4.20":

Applying: NOP-7
Using index info to reconstruct a base tree...
M	modules/k8s-nmstate-uninstall-operator.adoc
M	modules/nw-dns-cache-tuning.adoc
M	modules/nw-dns-forward.adoc
M	modules/nw-dns-view.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/nw-dns-view.adoc
Auto-merging modules/nw-dns-forward.adoc
Auto-merging modules/nw-dns-cache-tuning.adoc
CONFLICT (content): Merge conflict in modules/nw-dns-cache-tuning.adoc
Auto-merging modules/k8s-nmstate-uninstall-operator.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 NOP-7

Details

In response to this:

/cherrypick enterprise-4.22
/cherrypick enterprise-4.21
/cherrypick enterprise-4.20
/cherrypick enterprise-4.19
/cherrypick enterprise-4.18
/cherrypick enterprise-4.17
/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@JoeAldinger: #106087 failed to apply on top of branch "enterprise-4.21":

Applying: NOP-7
Using index info to reconstruct a base tree...
M	modules/nw-dns-cache-tuning.adoc
M	modules/nw-dns-view.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/nw-dns-view.adoc
Auto-merging modules/nw-dns-cache-tuning.adoc
CONFLICT (content): Merge conflict in modules/nw-dns-cache-tuning.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 NOP-7

Details

In response to this:

/cherrypick enterprise-4.22
/cherrypick enterprise-4.21
/cherrypick enterprise-4.20
/cherrypick enterprise-4.19
/cherrypick enterprise-4.18
/cherrypick enterprise-4.17
/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@JoeAldinger: new pull request created: #106763

Details

In response to this:

/cherrypick enterprise-4.22
/cherrypick enterprise-4.21
/cherrypick enterprise-4.20
/cherrypick enterprise-4.19
/cherrypick enterprise-4.18
/cherrypick enterprise-4.17
/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants