Add token-based auth prerequisite for oc adm upgrade recommend#112077
Open
asadawar wants to merge 1 commit into
Open
Add token-based auth prerequisite for oc adm upgrade recommend#112077asadawar wants to merge 1 commit into
asadawar wants to merge 1 commit into
Conversation
The recommend command requires a bearer token to query the Thanos monitoring route. Certificate-based auth (system:admin from the installer kubeconfig) causes the command to silently skip all alert-based precondition checks. Fixes: https://redhat.atlassian.net/browse/OSDOCS-19867
|
Hi @asadawar. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
oc adm upgrade recommenddocumentation noting that token-based authentication (e.g.,oc login -u kubeadmin) is requiredsystem:adminfrom the installer kubeconfig) causes the command to silently skip all alert-based precondition checksContext
Found during OCP 4.22 pre-GA hackathon testing of OCPSTRAT-2781. The Thanos monitoring route uses
kube-rbac-proxywith TokenReview-based auth only (no--client-ca-fileon port 9091), so certificate-based authentication is structurally impossible (source).Root cause discussed with OTA maintainer (W Trevor King): The real fix belongs to the monitoring team — either providing a dedicated Thanos-access SA or adding
--client-ca-fileto kube-rbac-proxy-web. OTA should not hardcode SA assumptions. This doc PR is a band-aid documenting the current token requirement.Test plan
system:adminproducesFailed to check for at least some preconditions: no token is currently in use for this sessionoc login -u kubeadminresolves the issue and all precheck categories are displayed--client-ca-file)oc create token <SA>works from cert auth but choosing the right SA is a monitoring team decisionFixes: https://redhat.atlassian.net/browse/OSDOCS-19867