[release-4.21] OCPBUGS-85149: Enable Gateway API tests on vSphere and baremetal#31139
[release-4.21] OCPBUGS-85149: Enable Gateway API tests on vSphere and baremetal#31139gcs278 wants to merge 11 commits intoopenshift:release-4.21from
Conversation
Update gatewayAPIController tests to skip certain tests with OLM dependencies when GatewayAPIWithoutOLM FeatureGate is enabled This will unblock openshift/cluster-ingress-operator#1354 by skipping any tests that require OLM capabilities without causing failures in the origin testing. JIRA link: https://redhat.atlassian.net/browse/NE-2292
This includes 5 unique tests which are to be used to graduate the featuregate from techpreview to GA. There are some tests which fall common within gatewayAPIController and GatewayAPIWithoutOLM. JIRA: https://redhat.atlassian.net/browse/NE-2292
Dual-stack support for Gateway API is not yet declared, skip the GatewayAPIController tests on AWS dual-stack clusters. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add support for running Gateway API e2e tests on vSphere and baremetal while gracefully handling missing LoadBalancer and DNS capabilities. On vsphere/baremetal without LoadBalancer/DNS: - Tests GatewayClass, Gateway, HTTPRoute creation/attachment - Tests OSSM/Istio integration - Skips LoadBalancer service validation - Skips DNS record validation - Skips HTTP connectivity tests https://redhat.atlassian.net/browse/NE-2286 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Fixed multiple instances where o.Expect(err).NotTo(o.HaveOccurred()) was used inside wait.PollUntilContextTimeout loops, causing tests to fail immediately instead of retrying when resources were not found. The pattern now matches the existing Subscription check which correctly handles errors by logging and returning false to retry. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Gateway API tests fail on IPv6 and dual-stack clusters, particularly on baremetal platforms where catalog sources are typically disabled. This prevents OSSM operator installation via OLM. Replace AWS-specific dual-stack check with platform-agnostic detection that checks the cluster's ServiceNetwork CIDRs for IPv6 addressing. This will skip Gateway API tests on: - Baremetal/vSphere/EquinixMetal IPv6 or dual-stack clusters - AWS dual-stack clusters - Any other platform with IPv6 networking Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
openshift-ci-robot
added
the
jira/valid-reference
|
@gcs278: This pull request references NE-2520 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.z" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci
Bot
added
the
approved
gcs278
changed the title
openshift-ci-robot
added
jira/severity-low
|
@gcs278: This pull request references Jira Issue OCPBUGS-85149, which is valid. 7 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/assign @rikatz |
|
/test okd-scos-images |
|
the test is valid, the strategy followed of backporting dependencies is required for this test, and the backports are guarded by featuregates /lgtm Thanks @gcs278 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gcs278, rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
oh darn the pre-submits aren't running automatically. |
|
Required tests + some hand picked optional tests: /test e2e-aws-csi |
|
/retest-required |
|
/hold I've made a wrong assumption - it looks like the So, we need to rethink this backport approach... |
openshift-ci
Bot
added
the
do-not-merge/hold
|
@gcs278: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
6 participants
Backport Gateway API test improvements to enable running on vSphere and baremetal platforms.
Backported PRs
Why
The primary goal is to backport #30946 which enables Gateway API e2e tests to run on vSphere and baremetal platforms by gracefully handling missing LoadBalancer and DNS capabilities. PRs #30599, #30896, #30905, and #30942 are prerequisites that #30946 builds on — they restructure the test file and add feature gate handling that #30946 depends on. Including the full chain ensures clean cherry-picks and avoids future merge conflicts if any of these changes need to be backported independently later.
The
GatewayAPIWithoutOLMfeature gate tests (#30896, #30905) are latent on 4.21 — they will simply skip if the feature gate is not enabled. This also conveniently sets us up for a backport of NE-2292 if that ever decides to happen.All cherry-picks applied cleanly with no conflicts.