chore: remove unused parameters and always-nil returns [SDCICD-1266] #3109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable the `unparam` linter to detect unused function parameters and return values that are never used or always return the same value. The unparam linter identifies: - Function parameters that are never used in the function body - Function parameters that always receive the same constant value - Return values that are never used by callers - Return values that always return the same value (e.g., always nil) This helps reduce code complexity, improve readability, and make function signatures more accurate by removing unnecessary elements. Changes: - Enable unparam linter in .golangci.yml - Remove always-nil error return from findJUnitFiles() - Remove unused startIdx parameter from extractFailureBlocks() (always 0) - Remove unused namespace parameter from pod() test helper (always ns1) - Remove always-empty image return from getUpgradeVersion() - Remove unused ctx parameter from runUpgrade() - Remove unused ns and kind parameters from createRolebinding() (always constants) - Remove always-nil error returns from manageSecrets() and manageSubscriptions() - Remove unused second int return from queryPrometheusAlerts() - Remove unused action parameter from osdClusterReadyHealthCheck() This is Stage 1 of a phased golangci-lint rollout plan to incrementally improve code quality across the codebase. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christophermancini The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Contributor
|
/test hypershift-pr-check |
Contributor
|
@christophermancini: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the
unparamlinter to detect unused function parameters and return values that are never used or always return the same value.The unparam linter identifies:
This helps reduce code complexity, improve readability, and make function signatures more accurate by removing unnecessary elements.
Changes:
This is Stage 1 of a phased golangci-lint rollout plan to incrementally improve code quality across the codebase.