Skip to content

feat: image updater changes#74517

Open
raelga wants to merge 8 commits intoopenshift:mainfrom
raelga:feat/image-updater-changes
Open

feat: image updater changes#74517
raelga wants to merge 8 commits intoopenshift:mainfrom
raelga:feat/image-updater-changes

Conversation

@raelga
Copy link
Contributor

@raelga raelga commented Feb 6, 2026

This pull request enhances the automation for image digest update PRs by introducing logic to notify users when a PR has been open for longer than a configurable threshold. It also adds a new environment variable for this threshold and updates relevant documentation. The most important changes are grouped below:

Notification improvements for stale PRs:

  • The script now checks the age of existing image digest update PRs. If a PR is found and its age exceeds the configured threshold, a notification is sent to prompt users to review or close it.
  • The final notification message about PR readiness is removed, as the new logic provides more context-sensitive notifications.

Configuration and documentation updates:

  • Added the PR_AGE_NOTIFICATION_HOURS environment variable to allow configuration of the age threshold for stale PR notifications, with a default value set in the script.
  • Updated the ref.yaml file to document the new PR_AGE_NOTIFICATION_HOURS variable and set its default to 10 hours.

Signed-off-by: Rael Garcia <rael@redhat.com>
Signed-off-by: Rael Garcia <rael@redhat.com>
@openshift-ci openshift-ci bot requested review from mmazur and roivaz February 6, 2026 13:20
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2026
Signed-off-by: Rael Garcia <rael@redhat.com>
Signed-off-by: Rael Garcia <rael@redhat.com>
@mmazur
Copy link
Member

mmazur commented Feb 6, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2026
@raelga
Copy link
Contributor Author

raelga commented Feb 6, 2026

/pj-rehearse periodic-ci-Azure-ARO-HCP-main-image-updater-image-updater-tooling

@openshift-ci-robot
Copy link
Contributor

@raelga: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@raelga
Copy link
Contributor Author

raelga commented Feb 6, 2026

/retest-required

Signed-off-by: Rael Garcia <rael@redhat.com>
@raelga
Copy link
Contributor Author

raelga commented Feb 9, 2026

/pj-rehearse periodic-ci-Azure-ARO-HCP-main-image-updater-image-updater-tooling

@openshift-ci-robot
Copy link
Contributor

@raelga: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 9, 2026

New changes are detected. LGTM label has been removed.

@raelga
Copy link
Contributor Author

raelga commented Feb 9, 2026

/pj-rehearse periodic-ci-Azure-ARO-HCP-main-image-updater-image-updater-tooling

@openshift-ci-robot
Copy link
Contributor

@raelga: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@raelga
Copy link
Contributor Author

raelga commented Feb 9, 2026

/pj-rehearse periodic-ci-Azure-ARO-HCP-main-image-updater-image-updater-tooling

@openshift-ci-robot
Copy link
Contributor

@raelga: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@raelga
Copy link
Contributor Author

raelga commented Feb 9, 2026

/pj-rehearse periodic-ci-Azure-ARO-HCP-main-image-updater-image-updater-tooling

@openshift-ci-robot
Copy link
Contributor

@raelga: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@raelga
Copy link
Contributor Author

raelga commented Feb 9, 2026

/pj-rehearse periodic-ci-Azure-ARO-HCP-main-image-updater-image-updater-tooling

@openshift-ci-robot
Copy link
Contributor

@raelga: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@raelga
Copy link
Contributor Author

raelga commented Feb 9, 2026

/retest

@raelga raelga force-pushed the feat/image-updater-changes branch from 44f1e02 to 902448b Compare February 9, 2026 15:23
@raelga
Copy link
Contributor Author

raelga commented Feb 9, 2026

/pj-rehearse periodic-ci-Azure-ARO-HCP-main-image-updater-image-updater-tooling

@openshift-ci-robot
Copy link
Contributor

@raelga: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@raelga
Copy link
Contributor Author

raelga commented Feb 9, 2026

/pj-rehearse periodic-ci-Azure-ARO-HCP-main-image-updater-image-updater-tooling

@openshift-ci-robot
Copy link
Contributor

@raelga: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

@raelga: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@raelga
Copy link
Contributor Author

raelga commented Feb 9, 2026

/pj-rehearse periodic-ci-Azure-ARO-HCP-main-image-updater-image-updater-tooling

@openshift-ci-robot
Copy link
Contributor

@raelga: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

3 similar comments
@openshift-ci-robot
Copy link
Contributor

@raelga: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@raelga: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@raelga: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@raelga
Copy link
Contributor Author

raelga commented Feb 9, 2026

/pj-rehearse periodic-ci-Azure-ARO-HCP-main-image-updater-image-updater-tooling

@openshift-ci-robot
Copy link
Contributor

@raelga: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@raelga, pj-rehearse: unable prepare a candidate for rehearsal; rehearsals will not be run. This could be due to a branch that needs to be rebased. ERROR:

couldn't checkout pull request: error fetching "pull/74517/head": exit status 128 fatal: unable to access 'https://github.com/openshift/release/': The requested URL returned error: 502

Signed-off-by: Rael Garcia <rael@redhat.com>
Signed-off-by: Rael Garcia <rael@redhat.com>
@raelga raelga force-pushed the feat/image-updater-changes branch from 6b32198 to 26e755b Compare February 9, 2026 17:01
@raelga
Copy link
Contributor Author

raelga commented Feb 9, 2026

/pj-rehearse periodic-ci-Azure-ARO-HCP-main-image-updater-image-updater-tooling

@openshift-ci-robot
Copy link
Contributor

@raelga: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@raelga
Copy link
Contributor Author

raelga commented Feb 9, 2026

/retest

@openshift-ci-robot
Copy link
Contributor

@raelga, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't checkout pull request: error fetching "pull/74517/head": exit status 128 remote: Internal Server Error
fatal: unable to access 'https://github.com/openshift/release/': The requested URL returned error: 500

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot
Copy link
Contributor

@raelga, pj-rehearse: unable prepare a candidate for rehearsal; rehearsals will not be run. This could be due to a branch that needs to be rebased. ERROR:

couldn't checkout pull request: error fetching "pull/74517/head": exit status 128 remote: Internal Server Error
fatal: unable to access 'https://github.com/openshift/release/': The requested URL returned error: 500

@raelga
Copy link
Contributor Author

raelga commented Feb 9, 2026

/retest
/pj-rehearse periodic-ci-Azure-ARO-HCP-main-image-updater-image-updater-tooling

@openshift-ci-robot
Copy link
Contributor

@raelga: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Signed-off-by: Rael Garcia <rael@redhat.com>
@raelga
Copy link
Contributor Author

raelga commented Feb 9, 2026

/pj-rehearse periodic-ci-Azure-ARO-HCP-main-image-updater-image-updater-tooling

@openshift-ci-robot
Copy link
Contributor

@raelga: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 9, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mmazur, raelga

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@raelga: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-Azure-ARO-HCP-main-image-updater-image-updater-tooling N/A periodic Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@raelga
Copy link
Contributor Author

raelga commented Feb 10, 2026

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 10, 2026

@raelga: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/step-registry-shellcheck e737ec0 link true /test step-registry-shellcheck
ci/rehearse/periodic-ci-Azure-ARO-HCP-main-image-updater-image-updater-tooling e737ec0 link unknown /pj-rehearse periodic-ci-Azure-ARO-HCP-main-image-updater-image-updater-tooling

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants