Skip to content
  •  
  •  
  •  
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,17 @@ images:
to: agent-iso-builder
promotion:
to:
- name: 4.22-priv
- name: 5.0-priv
namespace: ocp-private
releases:
initial:
integration:
name: 4.22-priv
name: 5.0-priv
namespace: ocp-private
latest:
integration:
include_built_images: true
name: 4.22-priv
name: 5.0-priv
namespace: ocp-private
resources:
'*':
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@ images:
to: agent-iso-builder
promotion:
to:
- disabled: true
name: 4.22-priv
- name: 4.22-priv
namespace: ocp-private
releases:
initial:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ images:
to: agent-iso-builder
promotion:
to:
- name: 5.0-priv
- disabled: true
name: 5.0-priv
namespace: ocp-private
releases:
initial:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,17 +38,17 @@ images:
to: get-collections
promotion:
to:
- name: 4.22-priv
- name: 5.0-priv
namespace: ocp-private
releases:
initial:
integration:
name: 4.22-priv
name: 5.0-priv
namespace: ocp-private
latest:
integration:
include_built_images: true
name: 4.22-priv
name: 5.0-priv
namespace: ocp-private
resources:
'*':
Expand Down Expand Up @@ -83,6 +83,70 @@ tests:
requests:
cpu: 100m
workflow: ipi-gcp
- always_run: false
as: e2e-ansible-fips
optional: true
steps:
cluster_profile: openshift-org-gcp
env:
FIPS_ENABLED: "true"
post:
- chain: ipi-deprovision
Comment on lines +93 to +94
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "=== ipi-gcp workflow definitions ==="
fd -a 'ipi-gcp.*\.ya?ml$' | while read -r f; do
  echo "--- $f"
  sed -n '1,220p' "$f"
done

echo
echo "=== ipi-deprovision chain definitions ==="
fd -a 'ipi-deprovision.*\.ya?ml$' | while read -r f; do
  echo "--- $f"
  sed -n '1,220p' "$f"
done

Repository: openshift/release

Length of output: 32170


Remove the extra ipi-deprovision post chains.

workflow: ipi-gcp already includes deprovision through its ipi-gcp-post chain. Adding explicit post: - chain: ipi-deprovision blocks causes deprovision to run twice, risking failed teardowns on otherwise successful jobs.

Suggested fix
-    post:
-    - chain: ipi-deprovision

Also applies to lines 116-117.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
post:
- chain: ipi-deprovision
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In
`@ci-operator/config/openshift-priv/ansible-operator-plugins/openshift-priv-ansible-operator-plugins-main.yaml`
around lines 93 - 94, Remove the duplicate explicit post chain entries that call
ipi-deprovision; the workflow ipi-gcp already triggers deprovision via its
ipi-gcp-post chain, so delete the post: - chain: ipi-deprovision blocks (the
ones adding ipi-deprovision) so deprovision only runs once (check the workflow
name ipi-gcp and its ipi-gcp-post chain and remove the extra ipi-deprovision
post entries).

test:
- as: test
cli: latest
commands: make -f openshift/Makefile test-e2e-ansible
dependencies:
- env: IMAGE_FORMAT
name: ansible-operator-e2e
from: src
resources:
requests:
cpu: 100m
workflow: ipi-gcp
- always_run: false
as: e2e-ansible-rhcos10-fips
optional: true
steps:
cluster_profile: openshift-org-gcp
env:
FEATURE_SET: TechPreviewNoUpgrade
FIPS_ENABLED: "true"
OSSTREAM: rhel-10
post:
- chain: ipi-deprovision
test:
- as: test
cli: latest
commands: make -f openshift/Makefile test-e2e-ansible
dependencies:
- env: IMAGE_FORMAT
name: ansible-operator-e2e
from: src
resources:
requests:
cpu: 100m
workflow: ipi-gcp
- always_run: false
as: e2e-ansible-rhcos10
optional: true
steps:
cluster_profile: openshift-org-gcp
env:
FEATURE_SET: TechPreviewNoUpgrade
OSSTREAM: rhel-10
test:
- as: test
cli: latest
commands: make -f openshift/Makefile test-e2e-ansible
dependencies:
- env: IMAGE_FORMAT
name: ansible-operator-e2e
from: src
resources:
requests:
cpu: 100m
workflow: ipi-gcp
- as: verify-deps
steps:
env:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ images:
to: get-collections
promotion:
to:
- disabled: true
name: 4.22-priv
- name: 4.22-priv
namespace: ocp-private
releases:
initial:
Expand Down Expand Up @@ -84,6 +83,70 @@ tests:
requests:
cpu: 100m
workflow: ipi-gcp
- always_run: false
as: e2e-ansible-fips
optional: true
steps:
cluster_profile: openshift-org-gcp
env:
FIPS_ENABLED: "true"
post:
- chain: ipi-deprovision
Comment on lines +93 to +94
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Drop the extra ipi-deprovision post chains.

These two jobs already use workflow: ipi-gcp, which includes cleanup in its post chain. Adding post: - chain: ipi-deprovision here causes teardown to run twice and can fail the job during cleanup.

Also applies to: 116-117

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In
`@ci-operator/config/openshift-priv/ansible-operator-plugins/openshift-priv-ansible-operator-plugins-release-4.22.yaml`
around lines 93 - 94, Remove the redundant post chain entries that call "chain:
ipi-deprovision" for jobs already using "workflow: ipi-gcp"; locate the job
blocks containing "workflow: ipi-gcp" and delete the "post:" -> "- chain:
ipi-deprovision" stanza (the instances shown by "post" and "chain:
ipi-deprovision" around the highlighted lines and the similar block at lines
116-117) so cleanup is only performed by the workflow's post chain.

test:
- as: test
cli: latest
commands: make -f openshift/Makefile test-e2e-ansible
dependencies:
- env: IMAGE_FORMAT
name: ansible-operator-e2e
from: src
resources:
requests:
cpu: 100m
workflow: ipi-gcp
- always_run: false
as: e2e-ansible-rhcos10-fips
optional: true
steps:
cluster_profile: openshift-org-gcp
env:
FEATURE_SET: TechPreviewNoUpgrade
FIPS_ENABLED: "true"
OSSTREAM: rhel-10
post:
- chain: ipi-deprovision
test:
- as: test
cli: latest
commands: make -f openshift/Makefile test-e2e-ansible
dependencies:
- env: IMAGE_FORMAT
name: ansible-operator-e2e
from: src
resources:
requests:
cpu: 100m
workflow: ipi-gcp
- always_run: false
as: e2e-ansible-rhcos10
optional: true
steps:
cluster_profile: openshift-org-gcp
env:
FEATURE_SET: TechPreviewNoUpgrade
OSSTREAM: rhel-10
test:
- as: test
cli: latest
commands: make -f openshift/Makefile test-e2e-ansible
dependencies:
- env: IMAGE_FORMAT
name: ansible-operator-e2e
from: src
resources:
requests:
cpu: 100m
workflow: ipi-gcp
- as: verify-deps
steps:
env:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,70 @@ tests:
requests:
cpu: 100m
workflow: ipi-gcp
- always_run: false
as: e2e-ansible-fips
optional: true
steps:
cluster_profile: openshift-org-gcp
env:
FIPS_ENABLED: "true"
post:
- chain: ipi-deprovision
test:
- as: test
cli: latest
commands: make -f openshift/Makefile test-e2e-ansible
dependencies:
- env: IMAGE_FORMAT
name: ansible-operator-e2e
from: src
resources:
requests:
cpu: 100m
workflow: ipi-gcp
- always_run: false
as: e2e-ansible-rhcos10-fips
optional: true
steps:
cluster_profile: openshift-org-gcp
env:
FEATURE_SET: TechPreviewNoUpgrade
FIPS_ENABLED: "true"
OSSTREAM: rhel-10
post:
- chain: ipi-deprovision
test:
- as: test
cli: latest
commands: make -f openshift/Makefile test-e2e-ansible
dependencies:
- env: IMAGE_FORMAT
name: ansible-operator-e2e
from: src
resources:
requests:
cpu: 100m
workflow: ipi-gcp
- always_run: false
as: e2e-ansible-rhcos10
optional: true
steps:
cluster_profile: openshift-org-gcp
env:
FEATURE_SET: TechPreviewNoUpgrade
OSSTREAM: rhel-10
test:
- as: test
cli: latest
commands: make -f openshift/Makefile test-e2e-ansible
dependencies:
- env: IMAGE_FORMAT
name: ansible-operator-e2e
from: src
resources:
requests:
cpu: 100m
workflow: ipi-gcp
- as: verify-deps
steps:
env:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ images:
to: get-collections
promotion:
to:
- name: 5.0-priv
- disabled: true
name: 5.0-priv
namespace: ocp-private
releases:
initial:
Expand Down Expand Up @@ -83,6 +84,70 @@ tests:
requests:
cpu: 100m
workflow: ipi-gcp
- always_run: false
as: e2e-ansible-fips
optional: true
steps:
cluster_profile: openshift-org-gcp
env:
FIPS_ENABLED: "true"
post:
- chain: ipi-deprovision
Comment on lines +94 to +95
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Drop the extra ipi-deprovision post chain.

The e2e-ansible-fips job uses workflow: ipi-gcp, which already includes cleanup in its post chain (ipi-gcp-post). Adding post: - chain: ipi-deprovision causes teardown to run twice, which can fail the job during cleanup.

🛠️ Proposed fix
   steps:
     cluster_profile: openshift-org-gcp
     env:
       FIPS_ENABLED: "true"
-    post:
-    - chain: ipi-deprovision
     test:
     - as: test
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
post:
- chain: ipi-deprovision
steps:
cluster_profile: openshift-org-gcp
env:
FIPS_ENABLED: "true"
test:
- as: test
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In
`@ci-operator/config/openshift-priv/ansible-operator-plugins/openshift-priv-ansible-operator-plugins-release-5.0.yaml`
around lines 94 - 95, Remove the extra post chain entry that causes duplicate
teardown: in the job named e2e-ansible-fips which uses workflow: ipi-gcp (whose
post chain ipi-gcp-post already performs cleanup), delete the explicit post: -
chain: ipi-deprovision stanza so ipi-deprovision is not run twice; ensure only
ipi-gcp-post remains responsible for teardown.

test:
- as: test
cli: latest
commands: make -f openshift/Makefile test-e2e-ansible
dependencies:
- env: IMAGE_FORMAT
name: ansible-operator-e2e
from: src
resources:
requests:
cpu: 100m
workflow: ipi-gcp
- always_run: false
as: e2e-ansible-rhcos10-fips
optional: true
steps:
cluster_profile: openshift-org-gcp
env:
FEATURE_SET: TechPreviewNoUpgrade
FIPS_ENABLED: "true"
OSSTREAM: rhel-10
post:
- chain: ipi-deprovision
Comment on lines +117 to +118
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Drop the extra ipi-deprovision post chain.

Same issue: the e2e-ansible-rhcos10-fips job uses workflow: ipi-gcp which already handles cluster cleanup. Remove the redundant post chain.

🛠️ Proposed fix
   steps:
     cluster_profile: openshift-org-gcp
     env:
       FEATURE_SET: TechPreviewNoUpgrade
       FIPS_ENABLED: "true"
       OSSTREAM: rhel-10
-    post:
-    - chain: ipi-deprovision
     test:
     - as: test
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
post:
- chain: ipi-deprovision
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In
`@ci-operator/config/openshift-priv/ansible-operator-plugins/openshift-priv-ansible-operator-plugins-release-5.0.yaml`
around lines 117 - 118, Remove the redundant post chain entry "ipi-deprovision"
from the job definition for e2e-ansible-rhcos10-fips: locate the job that
references workflow: ipi-gcp and delete the post: - chain: ipi-deprovision block
so the workflow's built-in cleanup (ipi-gcp) is relied upon instead of running a
duplicate deprovision chain.

test:
- as: test
cli: latest
commands: make -f openshift/Makefile test-e2e-ansible
dependencies:
- env: IMAGE_FORMAT
name: ansible-operator-e2e
from: src
resources:
requests:
cpu: 100m
workflow: ipi-gcp
- always_run: false
as: e2e-ansible-rhcos10
optional: true
steps:
cluster_profile: openshift-org-gcp
env:
FEATURE_SET: TechPreviewNoUpgrade
OSSTREAM: rhel-10
test:
- as: test
cli: latest
commands: make -f openshift/Makefile test-e2e-ansible
dependencies:
- env: IMAGE_FORMAT
name: ansible-operator-e2e
from: src
resources:
requests:
cpu: 100m
workflow: ipi-gcp
- as: verify-deps
steps:
env:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
base_images:
ansible_operator:
name: 4.22-priv
name: 5.0-priv
namespace: ocp-private
tag: ansible-operator
base:
name: 4.22-priv
name: 5.0-priv
namespace: ocp-private
tag: base
binary_build_commands: make openshift-ci-make-rpm
Expand All @@ -23,17 +23,17 @@ images:
to: ansible-service-broker
promotion:
to:
- name: 4.22-priv
- name: 5.0-priv
namespace: ocp-private
releases:
initial:
integration:
name: 4.22-priv
name: 5.0-priv
namespace: ocp-private
latest:
integration:
include_built_images: true
name: 4.22-priv
name: 5.0-priv
namespace: ocp-private
resources:
'*':
Expand Down
Loading