Skip to content

feat: add Data Router / ReportPortal integration for rhdh-plugin-export-overlays #78824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zdrapela wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: add Data Router / ReportPortal integration for rhdh-plugin-export-overlays #78824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a63ad47
feat: add Data Router / ReportPortal integration for rhdh-plugin-expo…
zdrapela May 5, 2026
0340690
fix: normalize attachment paths and derive install_method dynamically
zdrapela May 6, 2026
8a1702b
fix: rename JUnit file to junit-results-ocp-helm.xml
zdrapela May 6, 2026
854d859
fix: copy all junit files from playwright-report to SHARED_DIR
zdrapela May 6, 2026
c7a9d9c
fix: align process_junit_files glob with actual filenames
zdrapela May 6, 2026
71f7a45
Update container image for check-cluster-profiles (#78877)
deepsm007 May 5, 2026
d89a968
fix: use return instead of exit in data-router validate_required_vars
zdrapela May 6, 2026
e5985b3
fix: mark data-router post step as best_effort
zdrapela May 6, 2026
ac5ac55
feat: add data-router to auth-providers-nightly and helm-upgrade-nightly
zdrapela May 6, 2026
5dd8883
fix: add OWNERS file to send/ directory
zdrapela May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...eloper/rhdh-plugin-export-overlays/redhat-developer-rhdh-plugin-export-overlays-main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ tests:
optional: true
steps:
allow_skip_on_success: true
post:
- ref: redhat-developer-rhdh-plugin-export-overlays-send-data-router
- chain: gather
test:
- ref: redhat-developer-rhdh-plugin-export-overlays-ocp-helm
workflow: generic-claim
Expand All @@ -53,6 +56,9 @@ tests:
presubmit: true
steps:
allow_skip_on_success: true
post:
- ref: redhat-developer-rhdh-plugin-export-overlays-send-data-router
- chain: gather
test:
- ref: redhat-developer-rhdh-plugin-export-overlays-ocp-helm
workflow: generic-claim
Expand Down
6 changes: 6 additions & 0 deletions ci-operator/config/redhat-developer/rhdh/redhat-developer-rhdh-main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,9 @@ tests:
presubmit: true
steps:
allow_skip_on_success: true
post:
- ref: redhat-developer-rhdh-send-data-router
- chain: gather
test:
- ref: redhat-developer-rhdh-ocp-operator-nightly
workflow: generic-claim
Expand All @@ -341,6 +344,9 @@ tests:
presubmit: true
steps:
allow_skip_on_success: true
post:
- ref: redhat-developer-rhdh-send-data-router
- chain: gather
test:
- ref: redhat-developer-rhdh-ocp-helm-upgrade-nightly
workflow: generic-claim
Expand Down
3 changes: 3 additions & 0 deletions ci-operator/config/redhat-developer/rhdh/redhat-developer-rhdh-release-1.8.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,9 @@ tests:
presubmit: true
steps:
allow_skip_on_success: true
post:
- ref: redhat-developer-rhdh-send-data-router
- chain: gather
test:
- ref: redhat-developer-rhdh-ocp-operator-nightly
workflow: generic-claim
Expand Down
6 changes: 6 additions & 0 deletions ci-operator/config/redhat-developer/rhdh/redhat-developer-rhdh-release-1.9.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,9 @@ tests:
presubmit: true
steps:
allow_skip_on_success: true
post:
- ref: redhat-developer-rhdh-send-data-router
- chain: gather
Comment on lines +321 to +323
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

send-alert missing from nightly post steps — verify if intentional.

Every other cron-scheduled nightly job in this file (e.g., e2e-ocp-helm-nightly, e2e-ocp-v4-16-helm-nightly, e2e-ocp-operator-nightly) includes redhat-developer-rhdh-send-alert between send-data-router and chain: gather. The two newly wired nightly jobs omit it:

    post:
    - ref: redhat-developer-rhdh-send-data-router
    - chain: gather   # ← send-alert absent

If alerting is intentionally deferred for e2e-ocp-operator-auth-providers-nightly and e2e-ocp-helm-upgrade-nightly, a brief comment in the YAML would help future readers. Otherwise consider adding - ref: redhat-developer-rhdh-send-alert for parity:

🔧 Proposed change for parity with other nightly jobs 
     post:
     - ref: redhat-developer-rhdh-send-data-router
+    - ref: redhat-developer-rhdh-send-alert
     - chain: gather

The same pattern applies to the equivalent jobs in redhat-developer-rhdh-main.yaml (Lines 324-326, 347-349) and redhat-developer-rhdh-release-1.8.yaml (Lines 297-299).

Also applies to: 344-346

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/config/redhat-developer/rhdh/redhat-developer-rhdh-release-1.9.yaml`
around lines 321 - 323, The post steps for the nightly jobs
e2e-ocp-operator-auth-providers-nightly and e2e-ocp-helm-upgrade-nightly are
missing the redhat-developer-rhdh-send-alert ref that other nightlies include;
either insert a new post entry "- ref: redhat-developer-rhdh-send-alert"
immediately after "- ref: redhat-developer-rhdh-send-data-router" and before
"chain: gather" in those job definitions (and replicate the same change for the
equivalent jobs in main and release-1.8 manifests), or if omission is
intentional add a brief inline YAML comment in each job referencing the decision
to omit redhat-developer-rhdh-send-alert for future readers.

test:
- ref: redhat-developer-rhdh-ocp-operator-nightly
workflow: generic-claim
Expand All @@ -338,6 +341,9 @@ tests:
presubmit: true
steps:
allow_skip_on_success: true
post:
- ref: redhat-developer-rhdh-send-data-router
- chain: gather
test:
- ref: redhat-developer-rhdh-ocp-helm-upgrade-nightly
workflow: generic-claim
Expand Down
14 changes: 14 additions & 0 deletions ...xport-overlays/ocp/helm/redhat-developer-rhdh-plugin-export-overlays-ocp-helm-commands.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,11 @@ export CONTAINER_PLATFORM_VERSION
CONTAINER_PLATFORM_VERSION=$(oc version --output json 2>/dev/null | jq -r '.openshiftVersion' | cut -d'.' -f1,2 || echo "unknown")
echo "Platform: ${CONTAINER_PLATFORM} ${CONTAINER_PLATFORM_VERSION}"

# Save platform info to SHARED_DIR for data-router step
printf "%s" "${IS_OPENSHIFT}" > "${SHARED_DIR}/IS_OPENSHIFT.txt"
printf "%s" "${CONTAINER_PLATFORM}" > "${SHARED_DIR}/CONTAINER_PLATFORM.txt"
printf "%s" "${CONTAINER_PLATFORM_VERSION}" > "${SHARED_DIR}/CONTAINER_PLATFORM_VERSION.txt"

# ── Clone & checkout ─────────────────────────────────────────────────────────

git clone "https://github.com/${GITHUB_ORG_NAME}/${GITHUB_REPOSITORY_NAME}.git"
Expand Down Expand Up @@ -142,6 +147,9 @@ fi
INSTALLATION_METHOD="helm"
echo "RHDH_VERSION: ${RHDH_VERSION}, INSTALLATION_METHOD: ${INSTALLATION_METHOD}"

# Save RHDH version to SHARED_DIR for data-router step
printf "%s" "${RHDH_VERSION}" > "${SHARED_DIR}/RHDH_VERSION.txt"

# ── Artifact collection ──────────────────────────────────────────────────────

collect_artifacts() {
Expand All @@ -150,6 +158,12 @@ collect_artifacts() {
cp -a playwright-report "${ARTIFACT_DIR}/" 2>&1 || echo "[WARNING] playwright-report not found"
cp -a node_modules/.cache/e2e-test-results "${ARTIFACT_DIR}/" 2>&1 || echo "[WARNING] e2e-test-results not found"
fi
# Copy JUnit results to SHARED_DIR for data-router step
for junit_file in playwright-report/junit-*.xml; do
[[ -f "$junit_file" ]] || continue
cp "$junit_file" "${SHARED_DIR}/"
echo "[INFO] Copied $(basename "$junit_file") to ${SHARED_DIR}/"
done
}

# ── Post GitHub comment ──────────────────────────────────────────────────────
Expand Down
23 changes: 23 additions & 0 deletions ci-operator/step-registry/redhat-developer/rhdh-plugin-export-overlays/send/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# DO NOT EDIT; this file is auto-generated using https://github.com/openshift/ci-tools.
# Fetched from https://github.com/redhat-developer/rhdh root OWNERS
# If the repo had OWNERS_ALIASES then the aliases were expanded
# Logins who are not members of 'openshift' organization were filtered out
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md

approvers:
- josephca
- subhashkhileri
- gustavolira
- zdrapela
- rm3l
- kadel
- nickboldt
- jrichter1
options: {}
reviewers:
- albarbaro
- josephca
- subhashkhileri
- gustavolira
- zdrapela
- jrichter1
23 changes: 23 additions & 0 deletions ...erator/step-registry/redhat-developer/rhdh-plugin-export-overlays/send/data-router/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# DO NOT EDIT; this file is auto-generated using https://github.com/openshift/ci-tools.
# Fetched from https://github.com/redhat-developer/rhdh root OWNERS
# If the repo had OWNERS_ALIASES then the aliases were expanded
# Logins who are not members of 'openshift' organization were filtered out
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md

approvers:
- josephca
- subhashkhileri
- gustavolira
- zdrapela
- rm3l
- kadel
- nickboldt
- jrichter1
options: {}
reviewers:
- albarbaro
- josephca
- subhashkhileri
- gustavolira
- zdrapela
- jrichter1
Loading