Skip to content

[WIP] Use .ci-operator.yaml from rhobs/observability#80474

Open
simonpasquier wants to merge 1 commit into
openshift:mainfrom
simonpasquier:use-ci-operator-build-from-repo
Open

[WIP] Use .ci-operator.yaml from rhobs/observability#80474
simonpasquier wants to merge 1 commit into
openshift:mainfrom
simonpasquier:use-ci-operator-build-from-repo

Conversation

@simonpasquier

@simonpasquier simonpasquier commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

This PR migrates the RHOBS observability operator's CI configuration from a centralized model in the openshift/release repository to a distributed model where the source repository manages its own configuration.

Key Changes:

  • The rhobs-observability-operator-main.yaml configuration file now enables build_root.from_repository: true, instructing ci-operator to read the build definition from a .ci-operator.yaml file in the rhobs/observability source repository instead of relying on this centralized configuration
  • The hardcoded image_stream_tag reference (which previously pointed to an OpenShift 4.20 RHEL-9 golang image) has been removed, as the build root configuration will now be sourced from the repository

Impact:
This change decouples the observability operator's CI configuration from the openshift/release repository, allowing the RHOBS team to manage their CI settings directly in their source repository. This is a distributed configuration approach that is more maintainable and allows component teams greater autonomy over their CI/build pipeline definitions.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 12, 2026
@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 9de84e91-15d8-4ba1-ab35-fd49d9adcd36

📥 Commits

Reviewing files that changed from the base of the PR and between ba38a6a and 4106fad.

📒 Files selected for processing (1)
  • ci-operator/config/rhobs/observability-operator/rhobs-observability-operator-main.yaml

Walkthrough

The CI build configuration for the observability-operator is updated to set from_repository: true in the build root, replacing the previous external image stream tag reference to the OpenShift release stream.

Changes

Build root configuration update

Layer / File(s) Summary
Build root configuration update
ci-operator/config/rhobs/observability-operator/rhobs-observability-operator-main.yaml
The build_root is configured with from_repository: true, removing the prior image_stream_tag definition that referenced the release stream in the openshift namespace with an RHEL-9 golang/OpenShift 4.20 tag.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 13 | ❌ 2

❌ Failed checks (2 inconclusive)

Check name Status Explanation Resolution
Test Structure And Quality ❓ Inconclusive Custom check execution failed before a final verdict was produced. Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Ote Binary Stdout Contract ❓ Inconclusive Custom check execution failed before a final verdict was produced. Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
✅ Passed checks (13 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly relates to the main change: updating the build configuration to use .ci-operator.yaml from the rhobs/observability repository instead of the previous image_stream_tag definition.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR #80474 changes only ci-operator/rhobs-observability-operator-main.yaml; searches for Ginkgo-style It( / Describe( / Context( found no matches.
Microshift Test Compatibility ✅ Passed Verified rhobs-observability-operator-main.yaml sets build_root.from_repository: true and removes image_stream_tag; PR changes only this YAML, so no new Ginkgo e2e tests to assess for MicroShift co...
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR #80474 changes only ci-operator YAML (build_root.from_repository true; removes image_stream_tag). No Ginkgo e2e tests were added/modified, so no SNO multi-node assumptions to flag.
Topology-Aware Scheduling Compatibility ✅ Passed PR only updates ci-operator build_root.from_repository and removes build_root.image_stream_tag; no deployment manifests, controller code, or scheduling constraints were added/changed.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR #80474 changes only ci-operator/config/rhobs/observability-operator/rhobs-observability-operator-main.yaml (+1/−4); no new Ginkgo e2e tests added.
No-Weak-Crypto ✅ Passed The PR modifies a YAML CI-operator configuration file (rhobs-observability-operator-main.yaml) containing build instructions and cluster configurations. No weak cryptographic functions (MD5, SHA1,...
Container-Privileges ✅ Passed Inspected ci-operator/config/rhobs/observability-operator/rhobs-observability-operator-main.yaml: no privileged/hostPID/hostNetwork/hostIPC/SYS_ADMIN/allowPrivilegeEscalation/securityContext/runAsU...
No-Sensitive-Data-In-Logs ✅ Passed Checked rhobs-observability-operator-main.yaml for sensitive-log patterns (password/token/echo/printenv/curl/Authorization); none found, and change is build_root from_repository true only.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci

openshift-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2026
@openshift-ci

openshift-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

@simonpasquier: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/generated-config 4106fad link true /test generated-config

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant