NO-JIRA: feat: add sharding to tna recovery lanes 4.23 5.0

[eggfoobar]

Summary by CodeRabbit

This PR adds sharding configuration to the Triage Notification Assistant (TNA) recovery test job across two OpenShift versions. Specifically, it adds shard_count: 3 to the e2e-metal-ovn-two-node-fencing-recovery job in both the 4.23 and 5.0 nightly CI configurations. This change enables the recovery test to run in parallel across 3 shards, improving test execution efficiency in the OpenShift CI infrastructure for these release versions.

[openshift-ci-robot]

@eggfoobar: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: edc117ac-93ed-4a69-a072-8fed771cd1f9

📥 Commits

Reviewing files that changed from the base of the PR and between 2fa3c91 and e9df1a8.

⛔ Files ignored due to path filters (1)

• ci-operator/jobs/openshift/release/openshift-release-main-periodics.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (2)

• ci-operator/config/openshift/release/openshift-release-main__nightly-4.23.yaml
• ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml

---

Walkthrough

This PR adds shard count configuration to the e2e-metal-ovn-two-node-fencing-recovery test job across two OpenShift release nightly configurations (4.23 and 5.0), enabling parallel execution of the test with three shards.

Changes

Test job sharding configuration

Layer / File(s)	Summary
Add shard count to metal fencing recovery jobs ci-operator/config/openshift/release/openshift-release-main__nightly-4.23.yaml, ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml	The e2e-metal-ovn-two-node-fencing-recovery job receives shard_count: 3 configuration in both nightly release versions, enabling test parallelism.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

lgtm, approved, rehearsals-ack

Suggested reviewers

• umohnani8
• dkhater-redhat
• pruan-rht

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding shard_count: 3 configuration to the e2e-metal-ovn-two-node-fencing-recovery job for versions 4.23 and 5.0.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR adds only sharding config (shard_count: 3 and SHARD_ARGS) in CI YAML; no Ginkgo test title strings like It(/Describe(/Context(/When( appear in the diff.
Test Structure And Quality	✅ Passed	PR changes only ci-operator YAML job config (shard_count) and the repo contains no Ginkgo test code (no ginkgo imports; only Go unit tests for tools).
Microshift Test Compatibility	✅ Passed	PR #80484 only updates ci-operator release/job YAML to add sharding (shard_count/SHARD_ARGS) for existing e2e-metal-ovn-two-node-fencing-recovery; no new Ginkgo test code was added, so MicroShift c...
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR only updates existing ci-operator nightly YAML jobs (adds shard_count: 3); no Ginkgo/e2e test source changes found to introduce new multi-node/HA assumptions for SNO.
Topology-Aware Scheduling Compatibility	✅ Passed	PR adds shard_count: 3 to e2e-metal-ovn-two-node-fencing-recovery prow job in nightly 4.23/5.0; no scheduling constraints (anti-affinity/topology spread/control-plane selectors) introduced.
Ote Binary Stdout Contract	✅ Passed	PR contains only YAML configuration changes adding shard_count to job definitions. The OTE Binary Stdout Contract check applies to code-level violations in test binaries, not configuration metadata...
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR #80484 only updates CI YAML to add shard_count: 3 / SHARD_ARGS for e2e-metal-ovn-two-node-fencing-recovery; no new Ginkgo test code or IPv4/external connectivity logic added.
No-Weak-Crypto	✅ Passed	PR diff only adds shard_count/shard args to CI YAML; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or crypto/constant-time token/secret comparisons found.
Container-Privileges	✅ Passed	PR adds shard_count: 3 (and shard args in periodics.yaml); no privileged/hostPID/hostNetwork/hostIPC/SYS_ADMIN/allowPrivilegeEscalation/runAsUser:0 fields appear in the changed manifests.
No-Sensitive-Data-In-Logs	✅ Passed	Only shard_count: 3 was added to the recovery job in nightly-4.23 and nightly-5.0; no password/token/Authorization/BEGIN strings appear in the PR diff. citeturn6view9turn7view6turn7view7turn...

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@eggfoobar: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ovn-two-node-fencing-recovery-2of3	N/A	periodic	Periodic changed
periodic-ci-openshift-release-main-nightly-4.23-e2e-metal-ovn-two-node-fencing-recovery-1of3	N/A	periodic	Periodic changed
periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ovn-two-node-fencing-recovery-3of3	N/A	periodic	Periodic changed
periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ovn-two-node-fencing-recovery-1of3	N/A	periodic	Periodic changed
periodic-ci-openshift-release-main-nightly-4.23-e2e-metal-ovn-two-node-fencing-recovery-2of3	N/A	periodic	Periodic changed
periodic-ci-openshift-release-main-nightly-4.23-e2e-metal-ovn-two-node-fencing-recovery-3of3	N/A	periodic	Periodic changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-ci]

@eggfoobar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[dhensel-rh]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dhensel-rh, eggfoobar
Once this PR has been reviewed and has the lgtm label, please assign xueqzhan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/release/OWNERS
• ci-operator/jobs/openshift/release/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment