Make FIPS presubmit tests optional on main branch#80489
Open
redhat-chai-bot wants to merge 1 commit into
Open
Conversation
With the RHCOS 10 migration, there is an outstanding FIPS bug that causes FIPS presubmit tests to fail on main. Mark all non-cron FIPS presubmit tests as optional: true in the ci-operator configs for main-branch to unblock PRs. This affects 40 tests across 30 ci-operator config files (openshift, openshift-priv, backube orgs). Tests that already had optional: true or use cron scheduling are left unchanged.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (30)
📒 Files selected for processing (30)
WalkthroughThis PR marks 37 FIPS-related test entries as optional across CI operator configuration files in both the openshift and openshift-priv organizations, affecting job definitions for VolSync, CLI Manager, Console Dashboards Plugin, External Secrets Operator, JobSet Operator, and multiple other OpenShift projects. ChangesMark FIPS tests as optional in CI operator configurations
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Contributor
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
Contributor
|
@redhat-chai-bot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the RHCOS 10 migration, there is an outstanding FIPS bug that causes FIPS presubmit tests to fail on main. This PR marks all non-cron FIPS presubmit tests as
optional: truein the ci-operator configs for the main branch to unblock PRs.This affects 40 tests across 30 ci-operator config files (openshift, openshift-priv, backube orgs). Tests that already had
optional: trueor use cron scheduling are left unchanged.A companion revert PR will be opened to restore these tests to required status once the FIPS bug is resolved.
Summary by CodeRabbit
This PR marks FIPS presubmit tests as optional across 30 CI configuration files spanning the openshift, openshift-priv, and backube organizations. Approximately 40 FIPS-related tests—primarily FIPS-focused e2e tests and FIPS image scan tests—are being updated to include
optional: truein their test definitions.Context: A FIPS regression was introduced during the RHCOS 10 migration, causing FIPS presubmit tests to fail on the main branch. This PR temporarily unblocks PRs from being gated by these failing tests while the underlying bug is resolved. The changes affect CI operator configurations for component repositories including Origin, CLI Manager, External Secrets Operator, Secrets Store CSI Driver, JobSet Operator, Kubernetes Workload Scheduling, and Lightspeed Service, among others.
Scope: Only non-cron FIPS tests are marked optional; tests already configured as optional or using cron scheduling are left unchanged. A companion revert PR will restore these tests to required status once the FIPS issue is fixed.