Add weekly disconnected FAR E2E periodic job for medik8s/system-tests#80494
Add weekly disconnected FAR E2E periodic job for medik8s/system-tests#80494ugreener wants to merge 1 commit into
Conversation
|
/pj-rehearse auto-ack |
|
@ugreener: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
Warning Review limit reached
More reviews will be available in 6 minutes and 13 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
WalkthroughA new ci-operator YAML configuration file is added for the Medik8s system-tests repository targeting OpenShift 4.22 in disconnected mode. It specifies the UPI installer base image, nightly release candidate, wildcard resource requests, and a scheduled weekly E2E AWS disconnected test job. ChangesMedik8s 4.22 Disconnected CI Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openshift-ci
Bot
added
the
approved
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
@ugreener: no rehearsable tests are affected by this change |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
ci-operator/config/medik8s/system-tests/medik8s-system-tests-main__4.22-disconnected.yaml (1)
1-51:⚠️ Potential issue | 🔴 CriticalRename this file to follow the variant periodic configuration pattern and ensure generated job files are created.
Per CLAUDE.md guidance, files containing only periodic tests with
cron:orinterval:scheduling must use the__periodics.yamlsuffix pattern. This file should be renamed frommedik8s-system-tests-main__4.22-disconnected.yamltomedik8s-system-tests-main-4.22-disconnected__periodics.yamlto match the documented convention for release-specific periodic configurations.Additionally, verify that running
make updategenerates the corresponding periodic job file inci-operator/jobs/medik8s/system-tests/. The periodic job fore2e-far-weekly-aws-disconnectedshould appear in a separate-periodics.yamlfile.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/medik8s/system-tests/medik8s-system-tests-main__4.22-disconnected.yaml` around lines 1 - 51, The configuration file contains a periodic test (e2e-far-weekly-aws-disconnected) with cron scheduling but does not follow the required naming convention for periodic configurations. Rename the file from medik8s-system-tests-main__4.22-disconnected.yaml to medik8s-system-tests-main-4.22-disconnected__periodics.yaml to match the documented convention where the variant segment uses a hyphen instead of double underscore and __periodics is appended before the file extension. After renaming, run make update to verify that the corresponding periodic job file is generated in the ci-operator/jobs/medik8s/system-tests/ directory with the appropriate -periodics.yaml suffix.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/medik8s/system-tests/medik8s-system-tests-main__4.22-disconnected.yaml`:
- Around line 38-40: The inline test step contains an env block that declares
ECO_TEST_FEATURES by name only without a value, which is not the correct
ci-operator pattern. Environment variables are automatically propagated through
the test hierarchy from workflows and test definitions to their subordinate
stages and steps. Remove the entire env block (containing the name:
ECO_TEST_FEATURES declaration and from: src) from the test step configuration,
or if the variable must be explicitly passed to the container, replace it with a
proper dependencies mechanism reference instead of the bare name declaration.
---
Outside diff comments:
In
`@ci-operator/config/medik8s/system-tests/medik8s-system-tests-main__4.22-disconnected.yaml`:
- Around line 1-51: The configuration file contains a periodic test
(e2e-far-weekly-aws-disconnected) with cron scheduling but does not follow the
required naming convention for periodic configurations. Rename the file from
medik8s-system-tests-main__4.22-disconnected.yaml to
medik8s-system-tests-main-4.22-disconnected__periodics.yaml to match the
documented convention where the variant segment uses a hyphen instead of double
underscore and __periodics is appended before the file extension. After
renaming, run make update to verify that the corresponding periodic job file is
generated in the ci-operator/jobs/medik8s/system-tests/ directory with the
appropriate -periodics.yaml suffix.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 573e1ca3-1341-4a9a-9e03-1b257b2c0f5d
📒 Files selected for processing (1)
ci-operator/config/medik8s/system-tests/medik8s-system-tests-main__4.22-disconnected.yaml
ugreener
changed the title
ugreener
force-pushed
the
fix/far-disconnected-periodic-job
branch
2 times, most recently
from
f7a1566 to
c60a92d
Compare
openshift-merge-bot
Bot
removed
the
rehearsals-ack
ugreener
force-pushed
the
fix/far-disconnected-periodic-job
branch
from
c60a92d to
40d3dfd
Compare
|
/pj-rehearse auto-ack |
|
@ugreener: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@ugreener, |
|
@ugreener, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse periodic-ci-medik8s-system-tests-main-4.22-disconnected-e2e-far-weekly-aws-disconnected |
|
@ugreener: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Add weekly disconnected E2E test job for the FAR (fence-agents-remediation) operator. The job mirrors operator images to a private registry using the medik8s-disconnected-catalogsource step (PR openshift#79687), then installs FAR via OLM and runs the E2E suite on an air-gapped AWS cluster. Schedule: Sunday 10:00 UTC (staggered after connected FAR at 04:00, connected SBR at 06:00, and disconnected SBR at 08:00). Jira: RHWA-1038 Co-Authored-By: Claude <noreply@anthropic.com>
ugreener
force-pushed
the
fix/far-disconnected-periodic-job
branch
from
40d3dfd to
3f38f42
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse periodic-ci-medik8s-system-tests-main-4.22-disconnected-e2e-far-weekly-aws-disconnected |
|
@ugreener: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@ugreener: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Configuration is correct and follows established medik8s CI patterns.
There is an infrastructure issue (SSH key format in cluster profile), not a config problem, that I would like to see fixed before merging the PR (and use the PR to test it first).
I won't block the PR completely, so please unblock it if we can't wait.
/hold
| - as: e2e-far-weekly-aws-disconnected | ||
| capabilities: | ||
| - intranet | ||
| cron: 0 10 * * 0 |
There was a problem hiding this comment.
It seems like the rehearsal failure (mirror-images-check-registry-service) is caused by an SSH private key format issue in the medik8s-aws cluster profile:
Load key "/var/run/.../ssh-privatekey": invalid format
Permission denied (publickey,...)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: razo7, ugreener The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
Summary
Add a weekly disconnected E2E test job for the FAR (fence-agents-remediation) operator in the medik8s/system-tests Prow config. The job runs every Sunday at 10:00 UTC on an air-gapped AWS cluster, mirroring operator images via the
medik8s-disconnected-catalogsourcestep before installing and testing FAR.Changes
ci-operator/config/medik8s/system-tests/medik8s-system-tests-main__4.22-disconnected.yamle2e-far-weekly-aws-disconnectedusingopenshift-e2e-aws-disconnectedworkflowmedik8s-disconnected-catalogsourcefor image mirroring in air-gapped environmentmedik8s-operator-subscribefor OLM installation from mirrored catalog0 10 * * 0(staggered from connected FAR at 04:00, connected SBR at 06:00)Jira: RHWA-1038
Summary by CodeRabbit
This PR extends the OpenShift CI system-tests configuration for the medik8s/system-tests repository by adding a new periodic disconnected E2E job to validate the FAR (fence-agents-remediation) operator in air-gapped environments.
What’s being changed
ci-operator/config/medik8s/system-tests/medik8s-system-tests-main__4.22-disconnected.yamle2e-far-weekly-aws-disconnectedHow it works
0 10 * * 0) to avoid overlap with related periodic coverageopenshift-e2e-aws-disconnectedworkflow appropriate for disconnected AWS clustersmedik8s-disconnected-catalogsourcemedik8s-operator-subscribeECO_TEST_FEATURESwiring) and targets the intended OpenShift test refs/channelWhy it matters
CI workflow/testing automation notes
/pj-rehearse auto-acktwice to rehearse the job changes in CI prior to merging, with automatic acknowledgement after successful completion.