Skip to content

Update must-gather-clean CI to Go 1.25#80514

Open
neha037 wants to merge 2 commits into
openshift:mainfrom
neha037:bump-golang-must-gather-clean
Open

Update must-gather-clean CI to Go 1.25#80514
neha037 wants to merge 2 commits into
openshift:mainfrom
neha037:bump-golang-must-gather-clean

Conversation

@neha037

@neha037 neha037 commented Jun 15, 2026

Copy link
Copy Markdown

Summary

  • Update the build root image from rhel-9-release-golang-1.21-openshift-4.18 to rhel-9-release-golang-1.23-openshift-4.18 for must-gather-clean main, release-5.0, and release-5.1 branches.

Companion PR: openshift/must-gather-clean#120

Summary by CodeRabbit

This pull request updates the OpenShift CI configuration for the must-gather-clean project, changing the “make build” job’s builder (build root) image stream tag used by the ci-operator setup.

Across the three branches (main, release-5.0, release-5.1), it switches the build root from the RHEL 9 / OpenShift 4.18 Go 1.21 image to the RHEL 9 / OpenShift 4.22 Go 1.25 image by updating build_root.image_stream_tag.tag in:

  • ci-operator/config/openshift/must-gather-clean/openshift-must-gather-clean-main.yaml
  • ci-operator/config/openshift/must-gather-clean/openshift-must-gather-clean-release-5.0.yaml
  • ci-operator/config/openshift/must-gather-clean/openshift-must-gather-clean-release-5.1.yaml

Specifically, the tag is updated to rhel-9-release-golang-1.25-openshift-4.22.

Note: There’s a version mismatch to verify—this change is to Go 1.25 per the updated configuration and the commit message (“Update must-gather-clean CI to Go 1.25”), while the PR description/title indicates Go 1.23.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

Three CI operator configuration files for openshift/must-gather-clean (main, release-5.0, release-5.1) update the build_root.image_stream_tag.tag value from rhel-9-release-golang-1.21-openshift-4.18 to rhel-9-release-golang-1.25-openshift-4.22. No other fields are modified.

Changes

Build root Golang version bump for must-gather-clean

Layer / File(s) Summary
Build root image tag update
ci-operator/config/openshift/must-gather-clean/openshift-must-gather-clean-main.yaml, ci-operator/config/openshift/must-gather-clean/openshift-must-gather-clean-release-5.0.yaml, ci-operator/config/openshift/must-gather-clean/openshift-must-gather-clean-release-5.1.yaml
Replaces rhel-9-release-golang-1.21-openshift-4.18 with rhel-9-release-golang-1.25-openshift-4.22 in the build_root.image_stream_tag field of all three branch configurations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed This check is not applicable to this PR. The PR only modifies CI configuration YAML files, not any Ginkgo test code. No test names are present in the changed files.
Test Structure And Quality ✅ Passed The custom check reviews Ginkgo test code quality, but this PR only modifies CI configuration YAML files (builder image stream tags), not test code. The check is not applicable.
Microshift Test Compatibility ✅ Passed PR contains no new Ginkgo e2e tests. Only CI configuration YAML files were modified to update build image tags. Check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests are added in this PR. Changes are limited to CI configuration YAML files updating builder image stream tags. The SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR only modifies CI configuration files (build_root.image_stream_tag), not deployment manifests, operator code, or controllers. No scheduling constraints introduced.
Ote Binary Stdout Contract ✅ Passed PR only modifies CI configuration YAML files for must-gather-clean; no OTE binary code or stdout operations are involved in this CI configuration change.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR only updates CI operator YAML configuration files (build image tags), not Ginkgo e2e tests. The check only applies when new tests are added; no tests are added here.
No-Weak-Crypto ✅ Passed No weak cryptography, custom crypto implementations, or insecure token comparisons found. Changes are CI configuration updates only, not security-sensitive code.
Container-Privileges ✅ Passed PR contains only CI configuration updates with no container/K8s manifests defining privileged settings, hostPID, hostNetwork, hostIPC, SYS_ADMIN capabilities, or allowPrivilegeEscalation: true.
No-Sensitive-Data-In-Logs ✅ Passed PR contains only CI config updates to image stream tags with no logging statements exposing passwords, tokens, API keys, PII, or sensitive data.
Title check ✅ Passed The title accurately reflects the main change: updating must-gather-clean CI to use Go 1.25, which is consistently shown across all three modified configuration files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from janboll and sherine-k June 15, 2026 10:10
@tjungblu

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 15, 2026
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2026
@neha037 neha037 changed the title Update must-gather-clean CI to Go 1.23 Update must-gather-clean CI to Go 1.25 Jun 15, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@neha037: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-must-gather-clean-release-5.0-e2e openshift/must-gather-clean presubmit Ci-operator config changed
pull-ci-openshift-must-gather-clean-release-5.0-unit openshift/must-gather-clean presubmit Ci-operator config changed
pull-ci-openshift-must-gather-clean-release-5.0-verify openshift/must-gather-clean presubmit Ci-operator config changed
pull-ci-openshift-must-gather-clean-release-5.0-verify-deps openshift/must-gather-clean presubmit Ci-operator config changed
pull-ci-openshift-must-gather-clean-main-e2e openshift/must-gather-clean presubmit Ci-operator config changed
pull-ci-openshift-must-gather-clean-main-unit openshift/must-gather-clean presubmit Ci-operator config changed
pull-ci-openshift-must-gather-clean-main-verify openshift/must-gather-clean presubmit Ci-operator config changed
pull-ci-openshift-must-gather-clean-main-verify-deps openshift/must-gather-clean presubmit Ci-operator config changed
pull-ci-openshift-must-gather-clean-release-5.1-e2e openshift/must-gather-clean presubmit Ci-operator config changed
pull-ci-openshift-must-gather-clean-release-5.1-unit openshift/must-gather-clean presubmit Ci-operator config changed
pull-ci-openshift-must-gather-clean-release-5.1-verify openshift/must-gather-clean presubmit Ci-operator config changed
pull-ci-openshift-must-gather-clean-release-5.1-verify-deps openshift/must-gather-clean presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@tjungblu

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2026
@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neha037, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

@neha037: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants