Skip to content

Create 4.20 cluster pool with 3 nodes#80515

Open
evallesp wants to merge 1 commit into
openshift:mainfrom
evallesp:create-4.20-hive-clusterpool
Open

Create 4.20 cluster pool with 3 nodes#80515
evallesp wants to merge 1 commit into
openshift:mainfrom
evallesp:create-4.20-hive-clusterpool

Conversation

@evallesp

@evallesp evallesp commented Jun 15, 2026

Copy link
Copy Markdown

This patch creates a new 4.20 cluster pool using previously idle cluster deployment customizations (CDC-20, 21 and 22).

The cluster pool is initially configured with size: 0 to defer provisioning until needed.

Standardized CDC-21 and CDC-22 to use default c1.memory.large flavor for consistency across all pool clusters.

Summary by CodeRabbit

This PR establishes a new OpenShift 4.20 cluster pool for the OpenStack Kubernetes Operators testing infrastructure and standardizes the underlying cluster deployment customizations.

Changes to OpenShift CI infrastructure:

  1. New 4.20 Cluster Pool Created: A new ClusterPool resource (oko-op-09) has been added to support OpenShift 4.20 testing in the Vexxhost environment. The pool is configured with zero initial size to defer cluster provisioning until needed, and references three cluster deployment customizations (CDC-20, CDC-21, and CDC-22).

  2. CDC-21 and CDC-22 Standardization: Both customizations have been simplified by removing custom OpenStack compute flavor overrides. This allows them to default to the standard c1.memory.large flavor, ensuring consistency across the cluster pool. The customizations retain their network configuration (floating IP and external network patches) and cluster naming patches.

These changes enable efficient resource utilization by consolidating previously idle cluster deployments into a unified 4.20 cluster pool while maintaining standardized compute configurations.

This patch creates a new 4.20 cluster pool using previously idle
cluster deployment customizations (CDC-20, 21 and 22).

The cluster pool is initially configured with size: 0 to defer
provisioning until needed.

Standardized CDC-21 and CDC-22 to use default c1.memory.large
flavor for consistency across all pool clusters.

Signed-off-by: Enrique Vallespi Gil <evallesp@redhat.com>
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 15, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@evallesp: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: c2a38fb2-d015-495e-8075-b1aeadedb1db

📥 Commits

Reviewing files that changed from the base of the PR and between acdd633 and e4e92e9.

📒 Files selected for processing (3)
  • clusters/hosted-mgmt/hive/pools/openstack-k8s-operators/openstack-k8s-operators-4-20-vexxhost-hybrid_clusterpool.yaml
  • clusters/hosted-mgmt/hive/pools/openstack-k8s-operators/openstack-k8s-operators-cdc-vexx-21.yaml
  • clusters/hosted-mgmt/hive/pools/openstack-k8s-operators/openstack-k8s-operators-cdc-vexx-22.yaml
💤 Files with no reviewable changes (2)
  • clusters/hosted-mgmt/hive/pools/openstack-k8s-operators/openstack-k8s-operators-cdc-vexx-22.yaml
  • clusters/hosted-mgmt/hive/pools/openstack-k8s-operators/openstack-k8s-operators-cdc-vexx-21.yaml

Walkthrough

A new Hive ClusterPool manifest for OCP 4.20 on Vexxhost hybrid is added with capacity controls set to 0. Two existing ClusterDeploymentCustomization manifests (vexx-21, vexx-22) have their compute flavor/type override patches removed and replaced with a /metadata/name replace patch.

Changes

Vexxhost ClusterPool and CDC updates

Layer / File(s) Summary
New OCP 4.20 Vexxhost ClusterPool
clusters/hosted-mgmt/hive/pools/openstack-k8s-operators/openstack-k8s-operators-4-20-vexxhost-hybrid_clusterpool.yaml
Adds a complete ClusterPool manifest with pool identity, OCP 4.20 image set and version bounds, CDC inventory references, OpenStack platform credentials, pull secret, and all capacity/concurrency counts set to 0.
CDC patch updates for vexx-21 and vexx-22
clusters/hosted-mgmt/hive/pools/openstack-k8s-operators/openstack-k8s-operators-cdc-vexx-21.yaml, clusters/hosted-mgmt/hive/pools/openstack-k8s-operators/openstack-k8s-operators-cdc-vexx-22.yaml
Removes the computeFlavor and platform/openstack/type override patches from both CDC manifests and adds a replace operation for /metadata/name (oko-21 and oko-22 respectively).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Create 4.20 cluster pool with 3 nodes' accurately describes the main change: creating a new OpenShift 4.20 cluster pool with three cluster deployment customizations (CDC-20, CDC-21, CDC-22).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR contains only YAML Kubernetes/OpenShift manifests (ClusterPool and ClusterDeploymentCustomization resources); no Ginkgo test files present, so test naming check is not applicable.
Test Structure And Quality ✅ Passed Pull request contains only YAML configuration files (ClusterPool and ClusterDeploymentCustomization manifests); no Ginkgo test code exists to review, making the check not applicable.
Microshift Test Compatibility ✅ Passed This PR contains only YAML infrastructure manifests (ClusterPool and ClusterDeploymentCustomization resources), not Ginkgo e2e tests. The MicroShift test compatibility check does not apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR contains only YAML manifest changes for cluster pool/deployment customization configurations. No Ginkgo e2e tests (It(), Describe(), Context(), When()) were added, so SNO compatibility check is...
Topology-Aware Scheduling Compatibility ✅ Passed PR adds Hive ClusterPool and CDC manifests for cluster provisioning; contains no pod scheduling constraints (affinity, topology spread, PDB, nodeSelector) that would break non-HA topologies.
Ote Binary Stdout Contract ✅ Passed PR contains only YAML configuration manifests for OpenShift cluster pools; no executable code exists to violate the OTE stdout contract.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR adds only YAML manifest files (ClusterPool and ClusterDeploymentCustomization resources), not Ginkgo e2e tests. The check is not applicable.
No-Weak-Crypto ✅ Passed PR contains only YAML configuration files (Kubernetes/OpenShift manifests) with no cryptographic code, weak algorithms, or custom implementations.
Container-Privileges ✅ Passed The PR adds/modifies Hive ClusterPool and ClusterDeploymentCustomization resources containing no container specifications, securityContext configs, or privilege-escalation settings.
No-Sensitive-Data-In-Logs ✅ Passed PR adds/modifies only Kubernetes manifest YAML files with no logging code, hardcoded credentials, or logging configurations that expose sensitive data.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 15, 2026
@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Hi @evallesp. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: evallesp
Once this PR has been reviewed and has the lgtm label, please assign olliewalsh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot requested review from cjeanner and viroel June 15, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant