Skip to content

Remove node-density-heavy jobs#80517

Closed
rsevilla87 wants to merge 1 commit into
openshift:mainfrom
rsevilla87:remove-ndh-jobs
Closed

Remove node-density-heavy jobs#80517
rsevilla87 wants to merge 1 commit into
openshift:mainfrom
rsevilla87:remove-ndh-jobs

Conversation

@rsevilla87

@rsevilla87 rsevilla87 commented Jun 15, 2026

Copy link
Copy Markdown
Member

Nobody is looking at these jobs now

/cc @jtaleric @mohit-sheth

Summary by CodeRabbit

This PR removes two OpenShift QE performance scale CI configuration files that define nightly node-density-heavy Prow jobs:

  • openshift-eng-ocp-qe-perfscale-ci-main__4.21-nightly-node-density-heavy.yaml
  • openshift-eng-ocp-qe-perfscale-ci-main__4.22-nightly-node-density-heavy.yaml

Each file contained 194 lines of CI configuration including base image definitions, release candidate specifications, resource requests, and scheduled Prow job definitions for performance testing across multiple platforms (AWS, GCP, Azure, baremetal, IBM, Nutanix).

The author indicates these specific node-density-heavy jobs for the 4.21 and 4.22 nightly OCP releases are no longer being actively monitored or utilized. Note that the underlying node-density-heavy test infrastructure (step registry definitions and workflows) remains in the repository and continues to be used by other projects and test configurations.

Signed-off-by: Raul Sevilla <rsevilla@redhat.com>
@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: db699365-8e90-4f75-8e1f-b1685460866a

📥 Commits

Reviewing files that changed from the base of the PR and between 2c4f316 and a522edd.

⛔ Files ignored due to path filters (2)
  • ci-operator/jobs/openshift-eng/ocp-qe-perfscale-ci/openshift-eng-ocp-qe-perfscale-ci-main-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-eng/ocp-qe-perfscale-ci/openshift-eng-ocp-qe-perfscale-ci-main-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (2)
  • ci-operator/config/openshift-eng/ocp-qe-perfscale-ci/openshift-eng-ocp-qe-perfscale-ci-main__4.21-nightly-node-density-heavy.yaml
  • ci-operator/config/openshift-eng/ocp-qe-perfscale-ci/openshift-eng-ocp-qe-perfscale-ci-main__4.22-nightly-node-density-heavy.yaml
💤 Files with no reviewable changes (2)
  • ci-operator/config/openshift-eng/ocp-qe-perfscale-ci/openshift-eng-ocp-qe-perfscale-ci-main__4.21-nightly-node-density-heavy.yaml
  • ci-operator/config/openshift-eng/ocp-qe-perfscale-ci/openshift-eng-ocp-qe-perfscale-ci-main__4.22-nightly-node-density-heavy.yaml

Walkthrough

Two CI operator configuration YAML files are fully deleted: openshift-eng-ocp-qe-perfscale-ci-main__4.21-nightly-node-density-heavy.yaml and openshift-eng-ocp-qe-perfscale-ci-main__4.22-nightly-node-density-heavy.yaml. Each file had 194 lines covering all job definitions, image references, and metadata.

Changes

Cohort / File(s) Summary
Delete node-density-heavy CI configs
ci-operator/config/openshift-eng/ocp-qe-perfscale-ci/openshift-eng-ocp-qe-perfscale-ci-main__4.21-nightly-node-density-heavy.yaml, ci-operator/config/openshift-eng/ocp-qe-perfscale-ci/openshift-eng-ocp-qe-perfscale-ci-main__4.22-nightly-node-density-heavy.yaml
Both files are entirely removed (194 lines each). Each contained base_images, build_root, releases, resources, scheduled test job definitions across multiple cloud and baremetal platforms, and zz_generated_metadata.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

lgtm, approved, rehearsals-ack


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (2 errors)

Check name Status Explanation Resolution
Container-Privileges ❌ Error PR adds 76 instances of container privilege escalation settings including 32 privileged: true, 18 runAsUser: 0, 11 SYS_ADMIN capabilities, 10 hostNetwork: true, and 5 allowPrivilegeEscalation: true... Review and document justification for each privileged container setting or use least-privilege alternatives (non-root users, restricted security contexts, dropped capabilities).
No-Sensitive-Data-In-Logs ❌ Error PR adds node-density-heavy shell scripts with set -x enabled, which logs password/username variables to stderr when constructing ES_SERVER URL, exposing credentials in CI logs. Disable set -x before credential handling or use set +x/set -x to mask sensitive operations from logs.
✅ Passed checks (13 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Remove node-density-heavy jobs' directly and clearly describes the primary change: deletion of node-density-heavy job configuration files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed This PR modifies YAML CI configuration files (openshift-eng-ocp-qe-perfscale-ci-main__*.yaml), not Ginkgo test code. The custom check for stable test names is inapplicable to non-test configuration...
Test Structure And Quality ✅ Passed The custom check for "Test Structure and Quality" is designed to review Ginkgo test code, but this PR contains only CI operator configuration files (YAML), shell scripts, and metadata files being d...
Microshift Test Compatibility ✅ Passed PR removes CI configuration files only, not adding any new Ginkgo e2e tests. Custom check applies only when new e2e tests are added; this PR is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR removes CI configuration YAML files (node-density-heavy jobs), not adding any Ginkgo e2e tests. The SNO test compatibility check only applies when new Ginkgo tests are added, making it inap...
Topology-Aware Scheduling Compatibility ✅ Passed PR removes CI test configuration files (not workload definitions). Check targets deployment manifests, operators, or controllers being added/modified with scheduling constraints—none are present in...
Ote Binary Stdout Contract ✅ Passed PR removes only CI configuration YAML files and step-registry shell scripts/metadata; does not modify any test code or OTE binaries that could violate stdout contracts.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Custom check targets new Ginkgo e2e tests but this PR adds none. The commit contains only CI config YAML files and utility Go code (junit report tools, changelog tools) with zero Ginkgo test defini...
No-Weak-Crypto ✅ Passed PR removes CI config files and adds documentation/scripts with no weak crypto (MD5/SHA1/DES/RC4/3DES/Blowfish/ECB) or custom crypto implementations.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rsevilla87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2026
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 15, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@rsevilla87: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

@rsevilla87: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mehabhalodiya mehabhalodiya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rsevilla87, these jobs were created because we had testing to be done. You can watch it under this dashboard: https://redhat.atlassian.net/jira/dashboards/24559

In the attached dashboard, there are tickets for node-density-heavy workload, which analyzes 4.21 and 4.22. That's why these jobs were created.

@rsevilla87

Copy link
Copy Markdown
Member Author

Hi @rsevilla87, these jobs were created because we had testing to be done. You can watch it under this dashboard: https://redhat.atlassian.net/jira/dashboards/24559

In the attached dashboard, there are tickets for node-density-heavy workload, which analyzes 4.21 and 4.22. That's why these jobs were created.

Thanks for the answer @mehabhalodiya , I wasn't aware you were using these jobs. Closing this PR then

@rsevilla87 rsevilla87 closed this Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants