Force RHCOS 9 for FIPS nightly 5.0 jobs#80518
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughFive FIPS-related CI test job definitions in ChangesFIPS test jobs OS image stream configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
…solved Adds OS_IMAGE_STREAM: rhel-9 to all FIPS jobs on the 5.0 nightly payload so they install with RHCOS 9 instead of the default RHCOS 10: - e2e-aws-ovn-fips - e2e-aws-ovn-fips-serial - e2e-aws-ovn-upgrade-fips (also drives aggregated-aws-ovn-upgrade-5.0-micro-fips) - e2e-aws-ovn-upgrade-fips-no-nat-instance - e2e-gcp-ovn-fips Skipped: fips-payload-scan (not a cluster install), and e2e-gcp-ovn-rhcos10-fips-techpreview-serial (intentionally tests RHCOS 10). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml (1)
1456-1541: ⚡ Quick winVerify tracking mechanism for temporary workaround.
Since this is a temporary workaround for the RHCOS 10 FIPS bug (per PR objectives), ensure there's a tracking mechanism (e.g., linked bug/issue) to remember to revert these changes once the upstream bug is fixed.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml` around lines 1456 - 1541, The changes to the test configurations (e2e-aws-ovn-upgrade-fips-rhcos9-10-techpreview and related FIPS test cases) represent a temporary workaround for the RHCOS 10 FIPS bug. Ensure there is a linked bug or issue that tracks this temporary workaround and serves as a reminder to revert these changes once the upstream bug is fixed. Add a comment or reference in the configuration file or commit message that documents the associated bug/issue tracking number so the team knows when and why to remove these temporary modifications.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In
`@ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml`:
- Around line 1456-1541: The changes to the test configurations
(e2e-aws-ovn-upgrade-fips-rhcos9-10-techpreview and related FIPS test cases)
represent a temporary workaround for the RHCOS 10 FIPS bug. Ensure there is a
linked bug or issue that tracks this temporary workaround and serves as a
reminder to revert these changes once the upstream bug is fixed. Add a comment
or reference in the configuration file or commit message that documents the
associated bug/issue tracking number so the team knows when and why to remove
these temporary modifications.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 1dba0767-3b28-41c4-af52-a13e38236c44
📒 Files selected for processing (1)
ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@stbenjam: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
Summary
OS_IMAGE_STREAM: rhel-9to three FIPS jobs on the 5.0 nightly payload to work around an RHCOS 10 FIPS buge2e-aws-ovn-fips,e2e-aws-ovn-upgrade-fips(also drives the aggregated variant),e2e-aws-ovn-upgrade-fips-no-nat-instanceosImageStream: rhel-9in install-config.yaml so the installer uses RHCOS 9 boot imagesTest plan
osImageStream: rhel-9withoutFEATURE_SET: TechPreviewNoUpgrade(all existing usage of this field pairs it with TechPreview — this is the first attempt without it)🤖 Generated with Claude Code
Summary by CodeRabbit
This PR modifies the OpenShift 5.0 nightly payload CI configuration to work around a RHCOS 10 FIPS implementation bug. Specifically, it adds
OS_IMAGE_STREAM: rhel-9environment variable configuration to three AWS-based FIPS test jobs in the nightly pipeline:e2e-aws-ovn-fipse2e-aws-ovn-upgrade-fips(and its aggregated variant)e2e-aws-ovn-upgrade-fips-no-nat-instanceThe change directs the OpenShift installer to use RHCOS 9 boot images instead of the default RHCOS 10 for these FIPS-specific test jobs. This is a temporary workaround while the underlying RHCOS 10 FIPS bug is resolved.
The modification is applied to
ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yamland represents the first usage of theosImageStreamfield without requiring theFEATURE_SET: TechPreviewNoUpgradeflag, establishing a precedent for future non-preview use cases.