origin: allow missing architectures for the netshoot e2e image#82013
Conversation
openshift/origin#31396 adds ghcr.io/nicolaka/netshoot:v0.13 to the mirrored e2e image set (used by the ovn-kubernetes kubevirt e2e tests for the iperf test pods). The upstream image only publishes amd64 and arm64 manifests, so exempt it from the manifest list verification like the fedora-with-test-tooling containerdisk used by the same tests. Assisted-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Enrique Llorente <ellorent@redhat.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughThe image manifest verification configuration now allows missing architectures for ChangesImage Manifest Validation
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-origin-main-verify-image-manifest-lists |
|
@qinqon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jubittajohn, qinqon The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/pj-rehearse ack |
|
@jubittajohn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/label approved Actually OK, this is not adding the image just whitelisting in case someone else tries to use it somewhere |
|
@qinqon: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
…hift#82013) openshift/origin#31396 adds ghcr.io/nicolaka/netshoot:v0.13 to the mirrored e2e image set (used by the ovn-kubernetes kubevirt e2e tests for the iperf test pods). The upstream image only publishes amd64 and arm64 manifests, so exempt it from the manifest list verification like the fedora-with-test-tooling containerdisk used by the same tests. Assisted-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Enrique Llorente <ellorent@redhat.com>
openshift/origin#31396 adds
ghcr.io/nicolaka/netshoot:v0.13to the mirrored e2e image set — it is used by the ovn-kubernetes kubevirt e2e tests (openshift payload tests extension,openshift/network/virtualizationsuite) for the iperf server/client test pods.The upstream image only publishes amd64 and arm64 manifests (all netshoot tags, verified via skopeo), so
pull-ci-openshift-origin-main-verify-image-manifest-listsneeds an exemption — same as thee2e-quay-io-kubevirt-fedora-with-test-tooling-container-diskentry used by the same test family.Blocks: openshift/origin#31396 (which in turn is the last blocker for green
e2e-metal-ipi-ovn-bgp-virt-dualstackruns with the kubevirt tests enabled — openshift/ovn-kubernetes#3292 / #3294, CNV-92760).Summary by CodeRabbit
e2e-ghcr-io-nicolaka-netshootfrom missing-architecture checks, allowing the OVN-Kubernetes KubeVirt e2e tests to use its amd64/arm64-only manifests.