Skip to content

origin: allow missing architectures for the netshoot e2e image#82013

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
qinqon:netshoot-manifest-list-exception
Jul 16, 2026
Merged

origin: allow missing architectures for the netshoot e2e image#82013
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
qinqon:netshoot-manifest-list-exception

Conversation

@qinqon

@qinqon qinqon commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

openshift/origin#31396 adds ghcr.io/nicolaka/netshoot:v0.13 to the mirrored e2e image set — it is used by the ovn-kubernetes kubevirt e2e tests (openshift payload tests extension, openshift/network/virtualization suite) for the iperf server/client test pods.

The upstream image only publishes amd64 and arm64 manifests (all netshoot tags, verified via skopeo), so pull-ci-openshift-origin-main-verify-image-manifest-lists needs an exemption — same as the e2e-quay-io-kubevirt-fedora-with-test-tooling-container-disk entry used by the same test family.

Blocks: openshift/origin#31396 (which in turn is the last blocker for green e2e-metal-ipi-ovn-bgp-virt-dualstack runs with the kubevirt tests enabled — openshift/ovn-kubernetes#3292 / #3294, CNV-92760).

Summary by CodeRabbit

  • Updates OpenShift Origin CI image verification to exempt e2e-ghcr-io-nicolaka-netshoot from missing-architecture checks, allowing the OVN-Kubernetes KubeVirt e2e tests to use its amd64/arm64-only manifests.

openshift/origin#31396 adds ghcr.io/nicolaka/netshoot:v0.13 to the
mirrored e2e image set (used by the ovn-kubernetes kubevirt e2e tests
for the iperf test pods). The upstream image only publishes amd64 and
arm64 manifests, so exempt it from the manifest list verification like
the fedora-with-test-tooling containerdisk used by the same tests.

Assisted-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 5c96c651-6351-4d30-a945-676794e602d7

📥 Commits

Reviewing files that changed from the base of the PR and between 4f62488 and 2541b0f.

📒 Files selected for processing (1)
  • ci-operator/config/openshift/origin/openshift-origin-main.yaml

Walkthrough

The image manifest verification configuration now allows missing architectures for e2e-ghcr-io-nicolaka-netshoot.

Changes

Image Manifest Validation

Layer / File(s) Summary
Allow Netshoot missing architectures
ci-operator/config/openshift/origin/openshift-origin-main.yaml
Adds e2e-ghcr-io-nicolaka-netshoot to the command’s allowed missing-architectures list.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: pawanpinjarkar, smg247

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and specifically describes the main change: allowing missing architectures for the netshoot e2e image.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only a ci-operator YAML exemption changed; no Ginkgo test files or titles were added or modified.
Test Structure And Quality ✅ Passed This PR only changes a ci-operator YAML exemption; no Ginkgo test code was modified, so the test-structure review is not applicable.
Microshift Test Compatibility ✅ Passed The PR only changes a ci-operator YAML exemption; no Ginkgo tests or test bodies were added or modified.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only a ci-operator manifest-list exemption changed; no new or modified Ginkgo e2e tests were added, so SNO compatibility isn’t implicated.
Topology-Aware Scheduling Compatibility ✅ Passed Only a ci-operator image-manifest-lists exemption was added; no deployment manifests, controllers, affinity, nodeSelector, replica, or topology-sensitive scheduling logic changed.
Ote Binary Stdout Contract ✅ Passed Only a ci-operator YAML exemption changed; no OTE binary, TestMain, or suite-setup code was modified, so stdout contract risk is absent.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The commit only adds a CI manifest-list exemption in YAML; it introduces no new Ginkgo tests or networking behavior.
No-Weak-Crypto ✅ Passed Only a CI YAML exemption was added; no crypto code or weak algorithms/comparisons appear in the diff.
Container-Privileges ✅ Passed PR only adds an allow-missing-architectures exemption in ci-operator config; no privileged container or pod settings were introduced.
No-Sensitive-Data-In-Logs ✅ Passed Change only adds a manifest-list exemption for netshoot; no passwords, tokens, PII, hostnames, or customer data are logged or introduced.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from deads2k and sjenning July 16, 2026 13:54
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@qinqon: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-origin-main-verify-image-manifest-lists openshift/origin presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@qinqon

qinqon commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-origin-main-verify-image-manifest-lists

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@qinqon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jubittajohn

Copy link
Copy Markdown
Contributor

/retest

@jubittajohn

Copy link
Copy Markdown
Contributor

/lgtm
https://github.com/nicolaka/netshoot/blob/master/.github/workflows/release-buildx.yml#L49 shows this is released upstream with only linux/amd64,linux/arm64

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2026
@openshift-ci

openshift-ci Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jubittajohn, qinqon
Once this PR has been reviewed and has the lgtm label, please assign cpmeadors for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jubittajohn

Copy link
Copy Markdown
Contributor

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@jubittajohn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 16, 2026
@mkowalski

Copy link
Copy Markdown
Contributor

/label approved

Actually OK, this is not adding the image just whitelisting in case someone else tries to use it somewhere

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2026
@openshift-ci

openshift-ci Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

@qinqon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 78f426f into openshift:main Jul 16, 2026
15 checks passed
SachinNinganure pushed a commit to SachinNinganure/release that referenced this pull request Jul 20, 2026
…hift#82013)

openshift/origin#31396 adds ghcr.io/nicolaka/netshoot:v0.13 to the
mirrored e2e image set (used by the ovn-kubernetes kubevirt e2e tests
for the iperf test pods). The upstream image only publishes amd64 and
arm64 manifests, so exempt it from the manifest list verification like
the fedora-with-test-tooling containerdisk used by the same tests.

Assisted-By: Claude Fable 5 <noreply@anthropic.com>

Signed-off-by: Enrique Llorente <ellorent@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants