Skip to content

config: add stolostron/capi-tests CAPZ e2e jobs#3377

Open
RadekCap wants to merge 3 commits into
openshift:mainfrom
RadekCap:add-capz-qe-jobs
Open

config: add stolostron/capi-tests CAPZ e2e jobs#3377
RadekCap wants to merge 3 commits into
openshift:mainfrom
RadekCap:add-capz-qe-jobs

Conversation

@RadekCap

@RadekCap RadekCap commented Mar 27, 2026

Copy link
Copy Markdown

Summary

  • Add capz-qe section to openshift-customizations.yaml to register stolostron/capi-tests CAPZ e2e jobs in Sippy
  • Registers the periodic job (periodic-ci-stolostron-capi-tests-configure-prow-mgmt-periodics-capz-e2e and pull-ci-stolostron-capi-tests-configure-prow-mgmt-capz-e2e) by exact name

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Enabled a CAPZ end-to-end periodic CI job to run ongoing E2E validation for CAPZ components, improving QA coverage and helping catch regressions earlier.

@openshift-ci-robot

Copy link
Copy Markdown

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@coderabbitai

coderabbitai Bot commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: a68f6217-282a-46bf-92b9-7976ef5e063e

📥 Commits

Reviewing files that changed from the base of the PR and between 9903d05 and 49215c4.

📒 Files selected for processing (1)
  • config/openshift-customizations.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • config/openshift-customizations.yaml

Walkthrough

Adds a new top-level releases.capi-qe section to config/openshift-customizations.yaml and enables one CAPZ periodic job by setting releases.capi-qe.jobs.periodic-ci-stolostron-capi-tests-configure-prow-mgmt-periodics-capz-e2e: true.

Changes

Release Configuration

Layer / File(s) Summary
Add releases.capi-qe job flag
config/openshift-customizations.yaml
Adds releases.capi-qe release entry and sets releases.capi-qe.jobs.periodic-ci-stolostron-capi-tests-configure-prow-mgmt-periodics-capz-e2e: true.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 21
✅ Passed checks (21 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding CAPZ e2e jobs from stolostron/capi-tests to the configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Go Error Handling ✅ Passed PR contains only YAML config and documentation changes; no Go code modifications. Go error handling check is not applicable to this configuration-only pull request.
Sql Injection Prevention ✅ Passed PR only modifies YAML config files (config/openshift-customizations.yaml) with no SQL queries, database operations, or dynamic query construction present.
Excessive Css In React Should Use Styles ✅ Passed Custom check is inapplicable: PR only modifies YAML configuration file (config/openshift-customizations.yaml), not React components or CSS styling.
Test Coverage For New Features ✅ Passed This is a configuration-only change (YAML job registration) with no new Go code, functions, or methods, explicitly covered by the test coverage check's exception for "configuration-only changes".
Single Responsibility And Clear Naming ✅ Passed This PR only modifies a YAML configuration file (config/openshift-customizations.yaml), adding a release section. The check targets source code concepts (packages, structs, methods) which don't app...
Feature Documentation ✅ Passed PR makes a configuration-only change (adding a release section with one job entry). No API endpoints, data models, or core concepts changed. No existing feature docs in docs/features/ cover release...
Stable And Deterministic Test Names ✅ Passed PR modifies only config/openshift-customizations.yaml (a YAML configuration file). No Ginkgo test files or test code are modified, making this check not applicable.
Test Structure And Quality ✅ Passed PR contains only YAML configuration changes to config/openshift-customizations.yaml; no Ginkgo test code or test files are modified, making this quality check not applicable.
Microshift Test Compatibility ✅ Passed No Ginkgo e2e tests were added in this PR—only configuration changes to openshift-customizations.yaml. The check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR only modifies config/openshift-customizations.yaml to register existing tests with Sippy; no new Ginkgo e2e test code is added, so the SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR adds only CI job registration to openshift-customizations.yaml (Sippy config), not deployment manifests, operator code, or controllers with scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The PR only modifies config/openshift-customizations.yaml, a YAML configuration file. Sippy is a test result analysis tool, not an OTE binary. The check for OTE Binary Stdout Contract is not appl...
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR only adds configuration to register existing external jobs in openshift-customizations.yaml; it does not add new Ginkgo e2e test code, so the IPv6/disconnected network compatibility check d...
No-Weak-Crypto ✅ Passed PR adds only YAML config registering a CI job; no weak crypto (MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB), custom implementations, or insecure token/secret comparisons detected.
Container-Privileges ✅ Passed PR modifies a Sippy CI job configuration file, not a Kubernetes manifest. No container privilege, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation settings present.
No-Sensitive-Data-In-Logs ✅ Passed PR adds only a job name reference to YAML config with no logging statements, hardcoded credentials, or sensitive data exposure.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from deepsm007 and sosiouxme March 27, 2026 09:31
@openshift-ci-robot

Copy link
Copy Markdown

Scheduling required tests:
/test e2e

@marek-veber marek-veber left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2026
@RadekCap

Copy link
Copy Markdown
Author

/assign dgoodwin

@RadekCap

Copy link
Copy Markdown
Author

/retest

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2026
@openshift-ci

openshift-ci Bot commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

New changes are detected. LGTM label has been removed.

@openshift-ci

openshift-ci Bot commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: marek-veber, RadekCap
Once this PR has been reviewed and has the lgtm label, please ask for approval from dgoodwin. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot

Copy link
Copy Markdown

Scheduling required tests:
/test e2e

@RadekCap

Copy link
Copy Markdown
Author

Can anybody please do review here? Thank you. This is currently blocking our next work.

I wouldn't ping you all but I don't know where to ask properly and I don't want to ping you personally on Slack or elsewhere.

@deads2k
@deepsm007
@dgoodwin
@neisw
@petr-muller
@stbenjam
@xueqzhan
@sosiouxme
@smg247

Comment thread config/openshift-customizations.yaml Outdated
@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 8, 2026
@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Jun 9, 2026
RadekCap and others added 3 commits June 15, 2026 11:31
Register the CAPZ QE periodic and presubmit jobs in Sippy so they
appear in the dashboard.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace the overly broad regexp with an exact job entry for
pull-ci-stolostron-capi-tests-configure-prow-mgmt-capz-e2e.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Rename the section from capz-qe to capi-qe and remove the
pull-ci-stolostron-capi-tests-configure-prow-mgmt-capz-e2e job entry,
keeping only the periodic job.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 15, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e

@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

@RadekCap: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants