MPICT: Onboard Chaos variants for OCP 4.22

[oharan2]

Summary

Onboards OCP LP chaos jobs for OCP 4.22 into Sippy Component Readiness, so chaos test results appear in CR dashboards and are attributed to the correct Layered Product variant.

Changes

• pkg/variantregistry/ocp.go — Maps CI Operator job names containing -lpga-lp-chaos-cr--ocp- to the CR variant lp-chaos--ocp--lpGA
• config/views.yaml — Adds a new 4.22-LP-Chaos--lpGA CR view that includes lp-chaos--ocp--lpGA under LayeredProduct, scoped to owner mpict and network ovn, with regression tracking enabled

Summary by CodeRabbit

• Chores
  • Updated test infrastructure configuration and job classification patterns to support additional release variants and testing scenarios.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 3c088b27-a377-43ba-9d46-f9dc56c26b15

📥 Commits

Reviewing files that changed from the base of the PR and between 8d299ee and f31be72.

📒 Files selected for processing (2)

• config/views.yaml
• pkg/variantregistry/ocp.go

---

Walkthrough

Adds support for a new lp-chaos--ocp--lpGA layered product variant. A job-name substring pattern (-lpga-lp-chaos-cr--ocp-) is added to setLayeredProduct in ocp.go, and a corresponding 4.22-LP-Chaos--lpGA component readiness view is added to config/views.yaml with 4.21→4.22 release windows, OVN/mpict variant filters, and regression tracking enabled.

Changes

LP Chaos lpGA Variant and View

Layer / File(s)	Summary
Variant pattern match and component readiness view pkg/variantregistry/ocp.go, config/views.yaml	setLayeredProduct gains a -lpga-lp-chaos-cr--ocp- → lp-chaos--ocp--lpGA mapping; views.yaml adds a 4.22-LP-Chaos--lpGA block with ga/now 30-day release windows, LayeredProduct: lp-chaos--ocp--lpGA, Network: ovn, Owner: mpict, minimum_failure: 2, pass_rate_required_new_tests: 95, include_multi_release_analysis: true, metrics disabled, regression tracking enabled, and prime cache disabled.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 19 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Test Coverage For New Features	⚠️ Warning	The PR adds a new pattern to setLayeredProduct function in ocp.go but provides no test case for the new pattern. Existing tests do not cover the new '-lpga-lp-chaos-cr--ocp-' pattern variant classi...	Add a test case in TestVariantSyncer covering a job name matching the new pattern '-lpga-lp-chaos-cr--ocp-' to verify it correctly classifies the variant as 'lp-chaos--ocp--lpGA'.

✅ Passed checks (19 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly and clearly describes the main change: onboarding Chaos variants for OCP 4.22, which aligns with the config additions and variant registry changes across both modified files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Go Error Handling	✅ Passed	The PR adds a single line to the layeredProductPatterns array in setLayeredProduct function. This is a simple struct literal initialization with two strings, containing no error handling code and i...
Sql Injection Prevention	✅ Passed	No SQL injection vulnerabilities detected. Changes are static string pattern mappings in Go and YAML configuration with no SQL queries, dynamic code, or string concatenation with untrusted input.
Excessive Css In React Should Use Styles	✅ Passed	Custom check is not applicable to this PR—no React components or CSS styling present. Changes are YAML configuration and Go backend code only.
Single Responsibility And Clear Naming	✅ Passed	The PR changes follow single responsibility and clear naming principles. In ocp.go, setLayeredProduct has a single, well-defined responsibility (identifying layered product from job names), clear...
Feature Documentation	✅ Passed	No feature documentation updates were required; the PR only changes variant classification and component readiness configuration, which are not documented as features in docs/features/. The only do...
Stable And Deterministic Test Names	✅ Passed	The repository does not use Ginkgo testing framework; it uses standard Go testing with testify. The check for "stable and deterministic Ginkgo test names" is not applicable to this codebase.
Test Structure And Quality	✅ Passed	The PR does not contain any Ginkgo test code. It modifies config/views.yaml (+4004), pkg/variantregistry/ocp.go (+1338), and adds tests using standard Go testing (func TestXxx), not Ginkgo. Check i...
Microshift Test Compatibility	✅ Passed	PR adds no new Ginkgo e2e tests; only configuration and variant registry mappings for existing tests. MicroShift compatibility check not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR does not add new Ginkgo e2e tests; only configuration updates to variant registry and test views YAML file.
Topology-Aware Scheduling Compatibility	✅ Passed	This PR modifies Sippy, a test analysis tool for OpenShift CI, not an operator or deployment controller. Changes are purely configuration (views.yaml) and variant classification (ocp.go), with no d...
Ote Binary Stdout Contract	✅ Passed	Sippy is a Prow job analysis tool, not an OTE binary that communicates with openshift-tests. The PR modifies variant classification config and a simple pattern mapping—no process-level stdout opera...
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No Ginkgo e2e tests are added in this PR. Changes are configuration (config/views.yaml) and variant registry mapping (pkg/variantregistry/ocp.go) only.
No-Weak-Crypto	✅ Passed	PR adds only configuration and a simple string pattern for variant classification. No cryptographic operations, weak crypto algorithms, or insecure patterns were introduced.
Container-Privileges	✅ Passed	PR modifies configuration and Go source files (not K8s/container manifests) with no privileged container security settings detected.
No-Sensitive-Data-In-Logs	✅ Passed	Changes consist of configuration entries and pattern matching for variant classification. No new logging statements expose passwords, tokens, API keys, PII, or sensitive data; only team abbreviatio...

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: oharan2
Once this PR has been reviewed and has the lgtm label, please assign dgoodwin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

Scheduling required tests:
/test e2e

[openshift-ci]

@oharan2: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[oharan2]

/hold