Keep deployment patches in kustomization#81
Open
lpiwowar wants to merge 1 commit intoopenstack-lightspeed:mainfrom
Open
Keep deployment patches in kustomization#81lpiwowar wants to merge 1 commit intoopenstack-lightspeed:mainfrom
lpiwowar wants to merge 1 commit intoopenstack-lightspeed:mainfrom
Conversation
Retain patch modifications in config/manager/kustomization.yaml instead of removing them after bundle generation. This aligns with the pattern used in the openstack-k8s-operators namespace. The Makefile no longer removes the deployment patch, keeping the kustomization file consistent with the generated bundle. Implements request in this comment [1]. [1] openstack-lightspeed#80 (comment)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lpiwowar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
Code looks good to me! Not setting the label since I want @Akrog to take a look as he is the original person commenting on this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retain patch modifications in config/manager/kustomization.yaml instead of removing them after bundle generation. This aligns with the pattern used in the openstack-k8s-operators namespace.
The Makefile no longer removes the deployment patch, keeping the kustomization file consistent with the generated bundle.
Implements request in this comment [1].
[1] #80 (comment)