Add CI workflow and Containerfile for container image build by omkarjoshi0304 · Pull Request #1 · openstack-lightspeed/rhos-mcps

omkarjoshi0304 · 2026-02-10T15:50:04Z

Adds CI pipeline to build and push the container image to quay.io.

On PR: builds the image (no push)
On merge to main: builds and pushes to quay.io
Image tags: v0.1.0- and latest
[Build Image](podman pull quay.io/rh-ee-ojoshi/openstack-ls-mcp)

lpiwowar

Couple of things that crossed my mind while going through this for the first time:). Good start in a short time IMO! 🎉 👍

lpiwowar · 2026-02-11T09:25:57Z

Containerfile

+# Install the project and its dependencies
+RUN pip install --no-cache-dir .
+
+# Use the console_scripts entry point defined in pyproject.toml


issue (blocking): Let's add default user other than root.

lpiwowar · 2026-02-11T09:30:56Z

Containerfile

+COPY src/ src/
+
+# Install the project and its dependencies
+RUN pip install --no-cache-dir .


issue (blocking): Let's use pdm to install the dependencies here (pip install ignores the lockfile).

lpiwowar · 2026-02-11T09:33:46Z

Containerfile

+# Install the project and its dependencies
+RUN pip install --no-cache-dir .
+
+# Use the console_scripts entry point defined in pyproject.toml


issue (blocking): Let's add EXPOSE for docs purposes.

lpiwowar · 2026-02-11T09:43:28Z

.github/workflows/build-and-push-mcps.yaml

+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4


issue (blocking): Let's use the latest version from -> https://github.com/actions/checkout

changed it to checkout@v6

lpiwowar · 2026-02-11T09:44:16Z

Containerfile

+# NOTE: UBI9 does not yet provide a Python 3.13 image (only up to 3.12).
+# Since pyproject.toml requires python >= 3.13, we use the official Python
+# slim image. Switch to a UBI-based image when one becomes available.
+FROM python:3.13-slim


issue (blocking): Let's use full URL here.

lpiwowar · 2026-02-11T09:46:31Z

.github/workflows/build-and-push-mcps.yaml

+        uses: redhat-actions/buildah-build@v2
+        with:
+          image: ${{ github.event.repository.name }}
+          tags: v${{ env.VERSION }} latest


issue (blocking): Different people, different opinions:). But for now, I would follow the same pattern we use with the openstack-lightspeed/rag-content image. Use a commit hash only for the tag.

Akrog · 2026-02-11T10:37:46Z

Containerfile

+# NOTE: UBI9 does not yet provide a Python 3.13 image (only up to 3.12).
+# Since pyproject.toml requires python >= 3.13, we use the official Python
+# slim image. Switch to a UBI-based image when one becomes available.
+FROM python:3.13-slim


I'll change it to python 3.12 so we can use the UBI9 image

Akrog · 2026-02-11T10:49:01Z

Containerfile

+# Since pyproject.toml requires python >= 3.13, we use the official Python
+# slim image. Switch to a UBI-based image when one becomes available.
+FROM python:3.13-slim
+


Please add appropriate labels to the image.
References:

https://github.com/openstack-k8s-operators/cinder-operator/blob/b66ff139c9c4f923ce24fcaf9354e88ea4cb12da/Dockerfile#L55

https://github.com/embercsi/ember-csi/blob/a94897d13d3775c9e2db8b61be239803afa3eabe/Dockerfile-release#L8

Akrog · 2026-02-11T10:58:29Z

Containerfile

+
+# Install the project and its dependencies
+RUN pip install --no-cache-dir .
+


We should define a user and the workdir.
Reference: https://github.com/openstack-k8s-operators/cinder-operator/blob/main/Dockerfile

lpiwowar

Couple of things that need to be polished IMO:)

lpiwowar · 2026-02-16T12:48:13Z

pyproject.toml

 ]
 dependencies = ["mcp>=1.25.0", "openstackclient==4.0.0", "stevedore>=5.6.0", "pydantic>=2.12.5", "kubernetes>=35.0.0"]
-requires-python = "==3.12"
+requires-python = ">=3.12"


question (blocking): Why did you make this change? 👀 Also:

[lpiwowar@fedora rhos-mcps (OSPRH-25519)]$ pdm lock --check WARNING: Lockfile hash doesn't match pyproject.toml, packages may be outdated

and

... STEP 7/11: RUN pdm install --prod --no-editable --frozen-lockfile WARNING: Lockfile hash doesn't match pyproject.toml, packages may be outdated WARNING: Project requires a python version of >=3.12, The virtualenv is being created for you as it cannot be matched to the right version. ...

The original requires-python was "==3.12", which means exactly Python 3.12.0. The UBI9 base image ships Python 3.12.12. Since 3.12.12 != 3.12.0, pdm treated them as incompatible and tried to download a separate CPython 3.12.0 during the container build, which failed. Changed to >=3.12 so it accepts any Python 3.12.x (including the 3.12.12 in the UBI9 image) and future versions.

Regarding the lockfile mismatch — you're right, the pdm.lock in this PR is stale. I'll regenerate it with pdm lock and push an updated commit.

lpiwowar · 2026-02-16T12:57:04Z

Containerfile

+# Copy dependency and build files first for better layer caching
+COPY pyproject.toml pdm.lock README.md ./
+
+# Copy the source code


nit (non-blocking): These types of comments are not necessary. Nothing too complicated is happening here, hence no need to explain it:). I would rethink whether the other comments are really necessary in the containerfile as well.

lpiwowar · 2026-02-16T13:06:18Z

Containerfile

@@ -0,0 +1,32 @@
+FROM registry.access.redhat.com/ubi9/python-312:latest


suggestion (blocking): Short section in the readme about how to use the image could be nice:). No need to write the entire README. I think Gorka is working on this. For example, the REAMDE section can explain how can I use the image with custom configuration.

lpiwowar · 2026-02-17T11:37:24Z

README.md

+
+### Running the image
+```bash
+podman run -p 8080:8080 quay.io/openstack-lightspeed/rhos-mcps:latest


question: What if I want to use custom config.yaml file for the mcp server? [1]

[1] https://github.com/openstack-lightspeed/rhos-mcps/blob/main/config.yaml.sample

lpiwowar · 2026-02-17T11:39:37Z

README.md

+http://localhost:8080/mcp
+```
+
+### IDE configuration


suggestion (non-blocking): I personally would not put this here since this is about the consumption of the MCP. The users of this MCP should consult with the documentation from their IDEs IMO.

Add CI workflow and Containerfile for container image build

2022813

omkarjoshi0304 force-pushed the OSPRH-25519 branch from 3e68335 to 2022813 Compare February 10, 2026 16:12

lpiwowar reviewed Feb 11, 2026

View reviewed changes

Akrog requested changes Feb 11, 2026

View reviewed changes

omkarjoshi0304 force-pushed the OSPRH-25519 branch 2 times, most recently from d7d643b to fe38070 Compare February 11, 2026 16:36

chores: PR review fix

6bc1ba5

omkarjoshi0304 force-pushed the OSPRH-25519 branch from 9aacb18 to 6bc1ba5 Compare February 12, 2026 16:31

omkarjoshi0304 added 2 commits February 12, 2026 18:22

chore: python version fix

b9bde6c

Merge remote-tracking branch 'origin' into OSPRH-25519

c8ff641

omkarjoshi0304 force-pushed the OSPRH-25519 branch from a662a67 to c8ff641 Compare February 12, 2026 18:25

lpiwowar requested changes Feb 16, 2026

View reviewed changes

python version fix

ac779f7

omkarjoshi0304 force-pushed the OSPRH-25519 branch from 7f0f84f to ac779f7 Compare February 17, 2026 10:45

lpiwowar reviewed Feb 17, 2026

View reviewed changes


		# Install the project and its dependencies
		RUN pip install --no-cache-dir .

		@@ -0,0 +1,32 @@
		FROM registry.access.redhat.com/ubi9/python-312:latest

Conversation

omkarjoshi0304 commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lpiwowar left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lpiwowar left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

omkarjoshi0304 commented Feb 10, 2026 •

edited

Loading