feat(ip): implement SGCP DNS alias resource driver#1064
Closed
PaulJouvanceau wants to merge 1 commit into
Closed
Conversation
Add the resipsgcp_dnsalias driver to manage DNS aliases via the SGCP API. This driver supports create, update, delete, and status operations, following the same pattern as the existing resfssgcp_nfs driver. - Add T struct with keywords: uuid, name, target, zone_id, secret, endpoint - Implement Configure, Start, Stop, Status, Label, CanInstall, Boot methods - Use sgcp.DNSAPI for API calls, with authentication via token factory - Add aliasManager to handle createOrUpdate and delete logic - Add unit tests covering creation, update, deletion, status, and error cases - Add manifest.go to register driver and keywords The driver integrates with the SGCP configuration (sgcp.yaml) and uses the common http client cache and token factory from the sgcp package.
cgalibern
reviewed
Jul 8, 2026
cgalibern
reviewed
Jul 8, 2026
cgalibern
reviewed
Jul 8, 2026
cgalibern
reviewed
Jul 8, 2026
cgalibern
reviewed
Jul 8, 2026
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| api, server := newTestDNSAPI(t, func(w http.ResponseWriter, r *http.Request) (int, interface{}) { | ||
| if r.Method == http.MethodGet && r.URL.Path == "/aliases" { |
Contributor
There was a problem hiding this comment.
use the value from sgcp.yaml ("/alias")
Contributor
|
replaced by #1065 |
1 similar comment
Contributor
|
replaced by #1065 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.