PalletId-based subnet account Ids maintain subnet TAO reserves#2524
Draft
gztensor wants to merge 2 commits intodevnet-readyfrom
Draft
PalletId-based subnet account Ids maintain subnet TAO reserves#2524gztensor wants to merge 2 commits intodevnet-readyfrom
gztensor wants to merge 2 commits intodevnet-readyfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist:
subnetInfoRuntimeApi::getSubnetAccountIdfor clients to read the subnet account IDsSubnetTAOmap, migrate TAO stored inSubnetTAOinto subnet accounts. This will make balances palletTotalIssuancematch the subtensor palletTotalIssuance.Related Issue(s)
Type of Change
Breaking Change
The
SubnetTAOmap will be removed. Instead, clients should usesubnetInfoRuntimeApi::getSubnetAccountIdto get the account ID of the netuid reserve and thenpallet_system::accountto get the account balance.Checklist
./scripts/fix_rust.shto ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.