CVS-192366-move-models - #4470
Open
pgladkows wants to merge 10 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the functional-test pipeline/model scaffolding to reduce hard-coded model dependencies by removing several pipeline/custom-node helpers and switching some pipelines/MediaPipes to receive models via constructor arguments.
Changes:
- Removed unused custom node wrappers and multiple pipeline classes from the functional test suite.
- Updated several pipelines/MediaPipes to require explicit model(s) passed in, instead of constructing default models internally.
- Refactored
MultiLevelPipelineandImageClassificationMediaPipeto use injected model(s) rather than importing specific model classes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/functional/object_model/custom_node.py | Removes CustomNodeDemultiply and CustomNodeElastic1T helper classes. |
| tests/functional/constants/pipelines.py | Removes multiple pipeline helpers and updates pipeline/MediaPipe constructors to accept injected models; adjusts multi-level and image-classification pipeline wiring. |
Suppressed comments (1)
tests/functional/constants/pipelines.py:882
MultiLevelPipeline._create_nodes()reuses and mutates the same model instance (self.model) for every node (updatesnameand shapes). Because eachNodeholds a reference to the model, all nodes end up sharing the last mutated state, which breaks node naming/output naming and shape expectations.
model = self.model
model.name = f"{model.name}_{idx}"
model.update_shapes(shape)
model.set_input_shape_for_ovms(shape)
model_nodes.append(Node(f"model_{idx}", model))
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ngrozae
reviewed
Aug 26, 2026
pgladkows
force-pushed
the
CVS-192366-move-models
branch
from
August 27, 2026 12:19
7f5a9d6 to
c7d0708
Compare
mzegla
approved these changes
Aug 27, 2026
pgladkows
force-pushed
the
CVS-192366-move-models
branch
from
September 1, 2026 09:46
64744bd to
b694bfb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary
JIRA/Issue if applicable.
Describe the changes.
🧪 Checklist
``