Fix genai libs duplication - #4472
Open
michalkulakowski wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
This PR adjusts the packaging script to reduce duplicated/broad ELF patching by narrowing which shared libraries have their RPATH modified during release packaging.
Changes:
- Refactors
patchelfinvocation forovmsinto a multi-line guarded block. - Limits
patchelfRPATH updates to top-level.so*files in/ovms_release/libusingfind ... -exec ... +. - Replaces a broad plugin glob with a
findthat targetslib*plugin.so*files.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| find /ovms_release/lib/ -iname '*.so*' -exec patchelf --debug --remove-rpath {} \; | ||
| find /ovms_release/lib/ -iname '*.so*' -exec patchelf --debug --set-rpath '$ORIGIN/../lib' {} \; | ||
| if [ "$FUZZER_BUILD" == "0" ]; then | ||
| patchelf --remove-rpath ./ovms |
Comment on lines
+129
to
+130
| find /ovms_release/lib/ -maxdepth 1 -type f -iname '*.so*' -exec patchelf --debug --remove-rpath {} + | ||
| find /ovms_release/lib/ -maxdepth 1 -type f -iname '*.so*' -exec patchelf --debug --set-rpath '$ORIGIN/../lib' {} + |
Comment on lines
+129
to
+130
| find /ovms_release/lib/ -maxdepth 1 -type f -iname '*.so*' -exec patchelf --debug --remove-rpath {} + | ||
| find /ovms_release/lib/ -maxdepth 1 -type f -iname '*.so*' -exec patchelf --debug --set-rpath '$ORIGIN/../lib' {} + |
| patchelf --debug --set-rpath '$ORIGIN' /ovms_release/lib/libopenvino.so | ||
| patchelf --debug --set-rpath '$ORIGIN' /ovms_release/lib/libopenvino_tokenizers.so | ||
| patchelf --debug --set-rpath '$ORIGIN' /ovms_release/lib/lib*plugin.so | ||
| find /ovms_release/lib -maxdepth 1 -type f -name 'lib*plugin.so*' -exec patchelf --debug --set-rpath '$ORIGIN' {} + |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary
JIRA/Issue if applicable.
Describe the changes.
🧪 Checklist
``