Skip to content

Fix kokoro task detection #4477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michalkulakowski wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix kokoro task detection #4477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
545cf6b
Fix kokoro task detection
Aug 25, 2026
48562ec
Merge branch 'main' into mkulakow/fix_kokoro_task_detection
michalkulakowski Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/default_task_detector.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,7 @@ bool Text2SpeechDetector::scan(const ModelCatalogContext& ctx) const {
const std::string arch = a.GetString();
if (arch == "ParlerTTSForConditionalGeneration" ||
arch == "SpeechT5ForTextToSpeech" ||
arch == "KModel" || // Kokoro TTS
endsWith(arch, "ForTextToSpeech"))
return true;
}
Expand Down
4 changes: 4 additions & 0 deletions src/test/task_determine_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,10 @@ TEST(TaskDetectorTest, Text2SpeechDetectsNullArchWithNMels) {
auto ctx = makeCtx("kokoro", R"({"architectures":null,"n_mels":80})");
EXPECT_TRUE(ovms::Text2SpeechDetector{}.scan(ctx));
}
TEST(TaskDetectorTest, Text2SpeechDetectsKModelArch) {
auto ctx = makeCtx("kokoro", R"({"architectures":["KModel"],"n_mels":80})");
EXPECT_TRUE(ovms::Text2SpeechDetector{}.scan(ctx));
Comment on lines +160 to +162
}
TEST(TaskDetectorTest, Text2SpeechDoesNotMatchNullArchWithoutNMels) {
auto ctx = makeCtx("unknown", R"({"architectures":null})");
EXPECT_FALSE(ovms::Text2SpeechDetector{}.scan(ctx));
Expand Down