remove CompressionParameter#4108
Merged
andrey-churkin merged 1 commit intoJun 23, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the CompressionParameter abstraction from the PyTorch backend and eliminates the now-unused compression_lr_multiplier field from quantizer specs/config serialization, simplifying quantizer parameter handling and related tests.
Changes:
- Deleted
CompressionParameterfromnncf.torch.layer_utilsand replaced its uses with plaintorch.nn.Parameter. - Removed
compression_lr_multiplierfromPTQuantizerSpecconstructor/state, and from min-max backend quantizer construction. - Updated serialization test fixture to reflect the new quantizer config schema; updated mypy exclude list accordingly.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/torch/function_hook/test_serialization.py | Updates expected quantizer module config (drops compression_lr_multiplier). |
| src/nncf/torch/quantization/layers.py | Removes CompressionParameter usage and drops compression_lr_multiplier from PTQuantizerSpec. |
| src/nncf/torch/layer_utils.py | Removes the CompressionParameter class (leaves only StatefulModuleInterface). |
| src/nncf/quantization/algorithms/min_max/torch_backend.py | Stops passing compression_lr_multiplier when creating PTQuantizerSpec. |
| pyproject.toml | Removes src/nncf/torch/layer_utils.py from mypy’s exclude list. |
daniil-lyakhov
approved these changes
Jun 22, 2026
andrey-churkin
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Removed CompressionParameter
Reason for changes
Unused
Related tickets
Tests