Skip to content

refactor: deduplicate dual-timestep embedding interpolation - #315

Open
KakaruHayate wants to merge 1 commit into
openvpi:dual-timestepfrom
KakaruHayate:feat-integrate-dual-timestep
Open

refactor: deduplicate dual-timestep embedding interpolation#315
KakaruHayate wants to merge 1 commit into
openvpi:dual-timestepfrom
KakaruHayate:feat-integrate-dual-timestep

Conversation

@KakaruHayate

@KakaruHayate KakaruHayate commented Jul 31, 2026

Copy link
Copy Markdown

Summary

Review-only follow-up for openvpi/DiffSinger:dual-timestep. This PR keeps the feature behavior unchanged and centralizes the repeated timestep embedding and masked interpolation logic shared by WaveNet, LYNXNet, and LYNXNet2.

Base and scope

  • Base branch: openvpi/DiffSinger:dual-timestep
  • Base commit: 72981e4
  • This PR contains exactly one review-fix commit and changes only four files.

Changes

  • Add interpolate_dual_timestep_embedding in modules/commons/common_layers.py.
  • Use the helper in WaveNet, LYNXNet, and LYNXNet2.
  • Preserve WaveNet post-embedding MLP behavior and each backbone tensor layout.
  • Raise a clear error when a mask is passed without the second timestep.
  • Remove trailing whitespace introduced by the source branch.

Review source

Implements the CodeRabbit review feedback from KakaruHayate#53.

Validation

  • Python compileall: passed for modules/.
  • git diff --check: passed.
  • Runtime tensor tests were not run locally because the isolated Python environment does not include PyTorch.

@KakaruHayate
KakaruHayate changed the base branch from main to dual-timestep July 31, 2026 08:50
@KakaruHayate
KakaruHayate force-pushed the feat-integrate-dual-timestep branch from 48fa696 to c430936 Compare July 31, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant