shell.nix fix#5995
Open
banderlog wants to merge 1 commit into
Open
Conversation
solardiz
reviewed
Jun 4, 2026
| # then you can add 'intel-ocl' entry to 'nativeBuildInputs' below. Please | ||
| # note however if you are running and intel based system and remove intel-ocl then | ||
| # you will not have opencl support when building openwall/john. For the avoidance of | ||
| # doubt, this file does not contain any unfree software. |
Member
There was a problem hiding this comment.
We should probably remove the sentence "Please note ..." along with this update. There's also a typo in "and" in that sentence (which would be gone along with it).
Member
|
Please don't add commits - amend your first and only commit, and force-push. We don't want temporary history internal to one PR to stay in the project. |
banderlog
force-pushed
the
banderlog-patch-1
branch
from
43b64c6 to
143d5e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current shell.nix is broken, problem and fix were stated here: https://discourse.nixos.org/t/how-to-build-john-the-ripper-with-opencl-for-nvidia/42292
Also:
office2john.pywas missing