-
-
Notifications
You must be signed in to change notification settings - Fork 166
Configurable feedback email links show problem grader. #2872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Configurable feedback email links show problem grader. #2872
Conversation
1933242 to
e85dc6e
Compare
|
This is fine, and I agree that it's not good how the problem grader can take up so much space that you can't even see the problem when the page loads. Is there any interest in changing the interface for the problem grader? One thing I wonder about, is how the button to show/hide the grader re-renders the problem. Is that needed for some reason? If you have access to the grader, what if it just always appears, except that it has a collapse mechanism and starts out collapsed? |
|
We have talked about the grader is at the top to be close to the answer table which is no longer there. I agree that with the new feedback the grader should at least be at the bottom. |
|
I started messing with implementing a collapse approach as you requested. However, that is not going to work. The problem render is necessary. Not only to add the problem grader to the page, but to determine if correct answers should be shown to go with it. Those are, in my opinion, and essential thing to show with the problem grader, and that can't be done with the collapse approach. That would mean the correct answers would always be there, and that is certainly not desirable. Basically, there are server side decisions that are made based on whether the problem grader is to be shown or not, and those decisions can't be made if the problem grader is always shown. As @somiaj mentioned, we discussed moving the problem grader below the problem in a recent meeting. Originally that is where I had put it in homework sets, and still is there for tests. I moved it up in homework sets because that was requested, but that was when we still had the results table, and it made more sense to be closer to that. Now that the results table is gone, it doesn't need to be above anymore. |
|
Is it understood that when I suggested "always" showing the grader, I meant only under conditions where a user would currently have access to the Show Grader button. Not literally always. Also, I didn't exactly mean to request it. But I wanted to start discussing alternative solutions in case we can brainstorm something better. Maybe moving it down is better. |
|
I realize that, but even in that case we don't "always" want the correct answers to be shown. |
|
Perhaps if we always show the problem grader and correct answers when acting as another user it might work. |
|
That might defeat the purpose of the reveal button. By 'showing correct answers', the only difference is going to be if the reveal button is there or not? Could exposing the problem grader just remove the reveal buttons? |
This adds a new course configuration option that allows the instructor to choose if the problem grader will be open or not when the links sent in a feedback email from a problem are followed. I am finding that to be rather obtrusive, and not something that I ever want. I know I am not alone on this.
e85dc6e to
65687a3
Compare
This adds a new course configuration option that allows the instructor to choose if the problem grader will be open or not when the links sent in a feedback email from a problem are followed.
I am finding that to be rather obtrusive, and not something that I ever want. I know I am not alone on this.