feat: Implement Signals — step.waitForSignal / step.sendSignal / sendSignal#369
Draft
thejustinwalsh wants to merge 5 commits intoopenworkflowdev:mainfrom
Draft
Conversation
…d SignalTimeoutError Co-authored-by: thejustinwalsh <72912+thejustinwalsh@users.noreply.github.com>
Co-authored-by: thejustinwalsh <72912+thejustinwalsh@users.noreply.github.com>
…ignal parks Co-authored-by: thejustinwalsh <72912+thejustinwalsh@users.noreply.github.com>
Co-authored-by: thejustinwalsh <72912+thejustinwalsh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #350 (signals seed by @octoper), keeping the API surface identical while fixing bugs, hardening durability, and adding two missing features from the competitive analysis.
Summary
Open Questions
Bugs fixed
execution.ts): upstream threw SleepSignal at the first undelivered signal, silently skipping later-delivered ones in Promise.all([waitForSignal("A"), waitForSignal("B")]). Fixed with a two-phase approach.New features
Tests
95 passing execution tests (+14 net new vs #350), 224 backend tests.
Full details of development choices and itterations: thejustinwalsh#1