Conversation
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Split performance-tests into submodules and record the results of every run so they can be compared across commits. - jmh: the existing benchmarks and in-process throughput tests - e2e: reconciliation throughput of an operator against a real cluster - reporting: writes the measurements of both as JSON Results are keyed by commit, ordered by commit timestamp and indexed in index.json. The workflow runs on main and next, merges the results of all jobs and commits them to the performance-test-results branch. Also fixes PrimaryToSecondaryIndexBenchmark, which did not compile against the current onAddOrUpdate signature, and excludes the JMH generated classes from spotbugs so that the module passes verify.
jmh.version, maven-shade-plugin.version, the jackson-databind version and the operator-framework-core test-jar version were referenced but never defined, so the perf module POMs could not be parsed. skipPerformanceTests also got lost when the single module was split up.
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.