Skip to content

fix: rename version.properties to a unique name to avoid resource collisions - #415

Merged
csviri merged 1 commit into
operator-framework:mainfrom
afalhambra-hivemq:fix/unique-version-properties-resource
Sep 18, 2026
Merged

csviri merged 1 commit into
operator-framework:mainfrom
afalhambra-hivemq:fix/unique-version-properties-resource

Conversation

@afalhambra-hivemq

@afalhambra-hivemq afalhambra-hivemq commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Companion to operator-framework/java-operator-sdk#3627, fixed on the operator SDK side by operator-framework/java-operator-sdk#3628: kubernetes-webhooks-framework-core and operator-framework-core both generate a root-level version.properties, and the entries collide when the jars are merged into a shaded jar. Nothing in this repo reads the file, so this is only a rename of the generated resource.

Note for release notes: anyone reading version.properties directly from the kubernetes-webhooks-framework-core jar needs to switch to the new file name.

Summary by CodeRabbit

  • Chores
    • Updated the generated build metadata file name used by the application.

…lisions

Signed-off-by: Antonio Fernandez Alhambra <antonio.alhambra@hivemq.com>
@coderabbitai

coderabbitai Bot commented Sep 18, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 10146e14-af3a-4633-9e53-140a3250a69f

📥 Commits

Reviewing files that changed from the base of the PR and between f352926 and 1b2fcaa.

📒 Files selected for processing (1)
  • core/pom.xml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The Maven plugin configuration now writes generated Git properties to a framework-specific filename.

Changes

Git properties output

Layer / File(s) Summary
Maven output configuration
core/pom.xml
The generated Git properties filename changes to kubernetes-webhooks-framework-version.properties.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: actions-user

Merge Risk: ⚪ Minimal · up to 1b2fc

The generated resource is renamed as intended to avoid shaded-JAR collisions, with no unresolved in-repository compatibility risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: renaming version.properties to a unique filename to prevent resource collisions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@csviri csviri left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csviri
csviri merged commit 2e3c3c4 into operator-framework:main Sep 18, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants