Make Boatstack configuration controls enforce their documented behavior - #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The public guide treated every serialized JSON field as a user-facing control, while three workflow flags did not affect Boatstack's controller behavior. This made the configuration surface larger and less trustworthy than intended.
Impact
Repositories can disable human approval without fabricating approval provenance, disallow gap-bearing gate receipts, and require typed reviewer provenance for configured high-risk diffs. Existing schema-v1 human locks remain valid.
Validation
go test ./...python3 -m unittest labs/12-product-engineering-loop/tests/test_product_loop.pypython3 labs/12-product-engineering-loop/scripts/release_notes.py validate --root labs/12-product-engineering-loop/boatstack-distribution/release-notesgit diff --check