fix(boatstack): reconcile stale update receipts - #280
Merged
Conversation
Disclosure-Reviewed: reviewed — public-safe only, private facet kept out of this commit
Disclosure-Reviewed: reviewed — public-safe only, private facet kept out of this commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install-updatewithATOMIC_LOCALretry semantics when its repository postcondition no longer holdsWhy the earlier fix was incomplete
The earlier change repaired detached path ownership and invalid local provenance. Its end-to-end test stopped after the first successful update, so it did not cover a later restoration of the old committed pin while the detached success receipt survived. That receipt then suppressed regeneration.
Test plan
go vet ./...go build ./cmd/boatstack-helpergo test ./...bash -n ../boatstack-distribution/install.sh.templatepython3 -m unittest discover -s labs/12-product-engineering-loop/tests -p "test_*.py"Disclosure reviewed: public-safe implementation and synthetic fixtures only.