ci(pitot): dynamically execute all e2e CLI tests to enforce policy - #96
Merged
Conversation
- Register `gemini` adapter parsing the synchronous `BeforeTool` hook - Update Pitot CLI `hook` and `doctor` commands to recognize `gemini` - Add `e2e_gemini_cli_test.sh` to satisfy the supervisory control build gate - Update E2E and windtunnel testing coverage to ensure parity with Cursor/Claude/Codex boundaries - Append mandatory release note and sync public distribution JSON
Implements the standalone DeltaWire v1 Go CLI. - Strict JSON parsing and Draft 2020-12 schema validation - Matrix, rows, and variant generation - Managed outputs and strict path bounds - Full CI/validation scripts and tests
…orce adapter coverage - Added missing case blocks for gemini and opencode in the unified E2E runner. - Handled benign cursor warnings and empty output during real CLI execution to prevent spurious failures. - Added a structural Go test (e2e_coverage_test.go) to statically enforce that all registered adapters have a corresponding E2E test script, preventing this issue in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this change
The E2E tests for Pitot were hardcoded in the GitHub Actions workflow. Because of this, when a new adapter was added (like Gemini or Opencode), the Go test (
TestE2ECoverageSupervisoryControl) would pass by merely checking if a script file existed. However, the workflow wouldn't execute the script, meaning missing proxy implementations inside the unified runner were never caught in CI.What changed
pitot-lab.ymllabs/15-pitot/tests/e2e_*_cli_test.shscripts.This forces the CI to run the newly added E2E scripts for Gemini and Opencode, which will purposely fail and surface the missing proxy interception implementations that need fixing.