fix(proto-plugin): align Kittens UI with current OpenProject#26
Open
iam-deepaknagaraj wants to merge 1 commit intoopf:devfrom
Open
fix(proto-plugin): align Kittens UI with current OpenProject#26iam-deepaknagaraj wants to merge 1 commit intoopf:devfrom
iam-deepaknagaraj wants to merge 1 commit intoopf:devfrom
Conversation
- Replace removed `toolbar` helper with Primer PageHeader and SubHeader - Remove misleading sidebar hook demo text - Pass project_id on New Kitten link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the UI for the kittens index page and cleans up a plugin hook template. The main focus is on improving the kittens page header and action button using the new Primer components, and removing unused or placeholder content.
UI improvements on kittens index page:
toolbarwith the newPrimer::OpenProject::PageHeaderandSubHeadercomponents inapp/views/kittens/index.html.erb. This modernizes the page header, adds breadcrumbs, and updates the "New Kitten" button to use the new design system.Code cleanup:
app/views/hooks/proto_plugin/_view_layouts_base_sidebar.html.erband replaced it with a comment explaining the hook.