Skip to content

[#74753] Make Backlog, Sprints columns full height#23118

Merged
myabc merged 2 commits intorelease/17.4from
bug/74753-backlog-sprints-columns-full-height
May 8, 2026
Merged

[#74753] Make Backlog, Sprints columns full height#23118
myabc merged 2 commits intorelease/17.4from
bug/74753-backlog-sprints-columns-full-height

Conversation

@myabc
Copy link
Copy Markdown
Contributor

@myabc myabc commented May 7, 2026

Ticket

https://community.openproject.org/wp/74753

What are you trying to accomplish?

Warning

#22936 (commit 2f53d61) on dev also attempted to fix this issue, but renamed the CSS class incorrectly! Bear this in mind when merging the release branch back into dev.

Fixes a regression resulting from the Controller action rename in #22791 (commit afcdcdc).

See also #22534 (commit fc6a4fc) for the previous fix.

Screenshots

Before After
Screenshot 2026-05-07 at 23 27 39 Screenshot 2026-05-07 at 23 26 50

What approach did you choose and why?

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

Fix a regression resulting from the Controller action rename in #22791
(commit afcdcdc).

See also #22534 (commit fc6a4fc) for the previous fix.
myabc referenced this pull request May 7, 2026
The `sprint_planning` action was renamed to `backlog` in
#22740, but the corresponding body class selector in
`_master_backlog.sass` was missed.
@myabc myabc marked this pull request as ready for review May 7, 2026 21:29
Copilot AI review requested due to automatic review settings May 7, 2026 21:29
@myabc myabc added this to the 17.4.x milestone May 7, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a Backlogs layout regression by updating the page-scoped Sass selector to match the renamed controller/action so the sprint planning columns can stretch to full height again.

Changes:

  • Update the _master_backlog.sass scope selector from the old action-based class to the new Backlogs::BacklogController#show body classes.

Comment thread frontend/src/assets/sass/backlogs/_master_backlog.sass Outdated
Copy link
Copy Markdown
Contributor

@HDinger HDinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The copilot comment is valid, but I guess this will be fixed in the follow-up PR

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@myabc myabc merged commit 5e1a32a into release/17.4 May 8, 2026
14 of 15 checks passed
@myabc myabc deleted the bug/74753-backlog-sprints-columns-full-height branch May 8, 2026 08:21
@github-actions github-actions Bot locked and limited conversation to collaborators May 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

3 participants