Skip to content

기본 @Provide에서 initializer input을 지원한다 - #46

Merged
opficdev merged 7 commits into
developfrom
refactor/#45
Sep 7, 2026
Merged

opficdev merged 7 commits into
developfrom
refactor/#45

Conversation

@opficdev

@opficdev opficdev commented Sep 6, 2026

Copy link
Copy Markdown
Owner

🔗 연관된 이슈

🎯 작업 목적

기본 @Provide가 graph initializer input을 읽지 못해, 실제 지연 생성 의도와 관계없이 .lazy를 사용해야 하던 제약 해소

📝 작업 내용

📌 요약

  • @DependencyGraph(input: Input.self) 선언과 Macro 소유 init(input:) 생성 경로 추가
  • 기본 @Provide의 input 대입 뒤 eager shared 생성 보장
  • sources·overrides: true 조합의 input 전달 경로 확장
  • initializer input의 수명·제약 DocC 문서화

🔍 상세

  • graph가 input을 보관한 뒤 shared 저장소를 초기화하도록 생성 순서 구성
  • 기본 @Provide는 graph 생성 중 한 번 실행하고, .lazy는 최초 접근 시점, .transient는 매 접근 시점의 기존 동작 유지
  • shared helper의 input, self.input, closure capture 참조 전달과 지역 이름 가림 처리
  • OverrideBuilder.build(input:)와 source graph 조합에서 input → source → override 상태 → shared 저장소 순서 보장
  • actor graph와 @DependencyGraph(.shared) graph의 initializer input 사용 차단
  • initializer 충돌과 초기화가 필요한 stored property 사용 진단 추가
  • swift build, swift test, 변경 Swift 파일 SwiftLint, git diff --check 통과
  • DocC warnings-as-errors build 미수행

🔄 변경 흐름

flowchart LR
    input[initializer input] --> stored[graph input 저장]
    stored --> shared[기본 Provide shared 생성]
    shared --> accessor[동일 인스턴스 반환]
    stored --> lazy[lazy Provide 최초 접근 생성]
    lazy --> lazyAccessor[동일 인스턴스 반환]
Loading

@opficdev opficdev self-assigned this Sep 6, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-06T23:43:07.351929Z 9100621 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9100621847

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/Cradle/DependencyGraph.swift
Comment thread Sources/Cradle/Cradle.docc/Cradle.md
Comment thread Sources/CradleMacros/DependencyGraphMacro.swift Outdated
@opficdev
opficdev merged commit 7b84952 into develop Sep 7, 2026
5 checks passed
@opficdev
opficdev deleted the refactor/#45 branch September 7, 2026 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

기본 @Provide에서 initializer input을 지원한다

1 participant