기본 @Provide에서 initializer input을 지원한다 - #46
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9100621847
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
🎯 작업 목적
기본
@Provide가 graph initializer input을 읽지 못해, 실제 지연 생성 의도와 관계없이.lazy를 사용해야 하던 제약 해소📝 작업 내용
📌 요약
@DependencyGraph(input: Input.self)선언과 Macro 소유init(input:)생성 경로 추가@Provide의 input 대입 뒤 eager shared 생성 보장sources·overrides: true조합의 input 전달 경로 확장🔍 상세
input을 보관한 뒤 shared 저장소를 초기화하도록 생성 순서 구성@Provide는 graph 생성 중 한 번 실행하고,.lazy는 최초 접근 시점,.transient는 매 접근 시점의 기존 동작 유지input,self.input, closure capture 참조 전달과 지역 이름 가림 처리OverrideBuilder.build(input:)와 source graph 조합에서 input → source → override 상태 → shared 저장소 순서 보장@DependencyGraph(.shared)graph의 initializer input 사용 차단swift build,swift test, 변경 Swift 파일 SwiftLint,git diff --check통과🔄 변경 흐름
flowchart LR input[initializer input] --> stored[graph input 저장] stored --> shared[기본 Provide shared 생성] shared --> accessor[동일 인스턴스 반환] stored --> lazy[lazy Provide 최초 접근 생성] lazy --> lazyAccessor[동일 인스턴스 반환]