Skip to content

Patch 2 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
UganderD wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Patch 2 #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74b21d3
done
UganderD May 18, 2019
6b06171
commit changes
UganderD May 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions Jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
node {
stage('SCM CheckOut') {
git 'https://github.com/UganderD/TestJavaApp.git'

Copy link
Member

@iamabhishek-dubey iamabhishek-dubey Sep 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation is not quite right, please fix it


}
stage('Compile-Package'){
Copy link
Member

@iamabhishek-dubey iamabhishek-dubey Sep 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can have a better naming convention for stage

//Get maven home path
def mvnHOME = tool name: 'M2_HOME', type: 'maven'

sh "${mvnHOME}/bin/mvn package"
}
Copy link
Member

@iamabhishek-dubey iamabhishek-dubey Sep 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, try to add more CI steps like:-

  • Code Quality
  • Code Coverage
  • Unit Testing

stage('Deploy-Tomcat'){
sshagent(['tomcat-job1']) {
sh 'scp -o StrictHostKeyChecking=no target/*.war ec2-user@3.1.205.76:/opt/apache-tomcat-9.0.16/webapps/'
}
}
}