Fix Scala 3 compile error in GenIso after IsoFields return type change#1600
Merged
Conversation
PR #1574 changed IsoFields.apply to return PIso[S, S, ? <: Tuple, ? <: Tuple] but GenIso._fields still fed the result into `whitebox`, which expects Expr[Iso[S, A]]. The wildcard type no longer unifies with Iso[S, A], breaking macrosJVM compilation on every Scala 3 JVM job (the CI page only showed temurin@25 red because fail-fast cancelled the others). Cast the IsoFields result directly to Expr[Iso[S, Any]] in the fallback branch, matching the erased cast `whitebox` already performs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1574 changed IsoFields.apply to return
PIso[S, S, ? <: Tuple, ? <: Tuple] but GenIso._fields still fed the result into
whitebox, which expects Expr[Iso[S, A]]. The wildcard type no longer unifies with Iso[S, A], breaking macrosJVM compilation on every Scala 3 JVM job (the CI page only showed temurin@25 red because fail-fast cancelled the others).Cast the IsoFields result directly to Expr[Iso[S, Any]] in the fallback branch, matching the erased cast
whiteboxalready performs.