Repository navigation
fix(workflow): render agent prompts and publish final answers - #182
Merged
EricWvi merged 3 commits intoOct 27, 2026
Merged
Conversation
This was referenced Oct 26, 2026
ElephantGit
force-pushed
the
fix/676-agent-output-template
branch
from
October 27, 2026 02:22
b327040 to
42b1b91
Compare
ElephantGit
marked this pull request as ready for review
October 27, 2026 02:29
EricWvi
approved these changes
Oct 27, 2026
EricWvi
left a comment
Contributor
There was a problem hiding this comment.
owner review: 模板渲染、最终回答写入与 sessionEndReason 分离核对通过。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent prompts now resolve variable templates before dispatch, and successful session settlement publishes the initial turn's final complete assistant message as the node's output root. Named Output bindings and the linked IssueRun message can therefore carry the actual answer. Session evidence is stored separately in sessionEndReason; terminal historical runs are not backfilled.
The implementation reads durable assembled history for the current node attempt and initial turn, excludes failed/cancelled or unrelated turns, preserves committed output when the run is cancelled, and rejects truncated history. First dispatch and retry use the scoped variable pool used by conditions, including loop/iteration inputs.
Rebased onto main a4dfee1 after #179 merged. Compared with the previously validated b327040 candidate, this retains main's Output upgrade-compatibility documentation, container failure policy, state-budget enforcement, and timeout drain barriers. An additional fix keeps drain diagnostics in sessionEndReason instead of Agent output roots and preserves Agent failure diagnostics in run-level errors. Loop/iteration timeout tests now assert that both live and archived states have no output root. This PR adds no migrations.
Validation: PostgreSQL-backed workflow regressions, the full Go race suite, formatting, Go lint (0 issues), and OpenAPI regeneration consistency passed locally. All new-head CI checks passed: frontend, packages, four integration shards, and the final complete/disjoint coverage aggregate. CI proto lint, breaking-change detection and generation drift checks passed (local generation could not reach the remote plugin service). The frontend generated-client diff remains comments only.
ADR: implements the existing variable-root and execution-context obligations in specs/decisions/cloud/workflow/0-cloud-side-scheduler-owns-workflow-execution.md, whose status remains implemented. It adds no architectural decision and preserves the approved loop/iteration ownership and cancellation semantics. A separate specs follow-up under the parent task will remove the known-gap note and synchronize core-case evidence after review and acceptance; this PR does not prematurely change that evidence.
Real-model acceptance passed for b327040 before this rebase. That result is not acceptance of the new head. Full post-merge main acceptance remains assigned to the existing follow-up.
Refs ora-space/circus#676