Skip to content

[GR-79213] Fix regression in c-call-method-int-float #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graalvmbot merged 1 commit into from
Sep 2, 2026
+0 −16
Merged

[GR-79213] Fix regression in c-call-method-int-float #1123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions graalpython/com.oracle.graal.python.cext/src/capi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,18 +418,6 @@ static void initialize_gc_types_related_slots() {
_PyWeakref_RefType.tp_free = &GraalPyPrivate_Object_GC_Del;
}

int is_builtin_type(PyTypeObject *tp) {
#define PY_TRUFFLE_TYPE_GENERIC(GLOBAL_NAME, __TYPE_NAME__, a, b, c, d, e, f, g) (tp == &GLOBAL_NAME) ||
#define PY_TRUFFLE_TYPE_LOCAL(GLOBAL_NAME, __TYPE_NAME__, a, b) (tp == &GLOBAL_NAME) ||
#define PY_TRUFFLE_TYPE_EXTERN(GLOBAL_NAME, __TYPE_NAME__) PY_TRUFFLE_TYPE_GENERIC(GLOBAL_NAME, __TYPE_NAME__, 0, 0, 0, 0, 0, 0, 0)
#define PY_TRUFFLE_TYPE_UNIMPLEMENTED(GLOBAL_NAME) // empty
return PY_TYPE_OBJECTS 0;
#undef PY_TRUFFLE_TYPE_GENERIC
#undef PY_TRUFFLE_TYPE_LOCAL
#undef PY_TRUFFLE_TYPE_EXTERN
#undef PY_TRUFFLE_TYPE_UNIMPLEMENTED
}

/** to be used from Java code only; calls '_Py_Dealloc' */
GraalPy_CAPI_HELPER_SYMBOL Py_ssize_t
GraalPyPrivate_BulkDealloc(intptr_t ptrArray[], int64_t len)
Expand Down
2 changes: 0 additions & 2 deletions graalpython/com.oracle.graal.python.cext/src/capi.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,8 +285,6 @@ GraalPyPrivate_Log(int level, const char *format, ...)
}
}

Py_LOCAL_SYMBOL int is_builtin_type(PyTypeObject *tp);

// export the SizeT arg parse functions, because we use them in contrast to cpython on windows for core modules that we link dynamically
PyAPI_FUNC(int) _PyArg_Parse_SizeT(PyObject *, const char *, ...);
PyAPI_FUNC(int) _PyArg_ParseTuple_SizeT(PyObject *, const char *, ...);
Expand Down
2 changes: 0 additions & 2 deletions graalpython/com.oracle.graal.python.cext/src/typeobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2546,8 +2546,6 @@ is_subtype_with_mro(PyObject *a_mro, PyTypeObject *a, PyTypeObject *b)
return PyType_FastSubclass(a, Py_TPFLAGS_DICT_SUBCLASS);
} else if ((PyObject *)b == PyExc_BaseException) {
return PyType_FastSubclass(a, Py_TPFLAGS_BASE_EXC_SUBCLASS);
} else if (is_builtin_type(a) && !is_builtin_type(b)) {
return 0;
}
int res;
if (a_mro != NULL) {
Expand Down
Loading