-
Notifications
You must be signed in to change notification settings - Fork 5
Selet AI Tests for Vector Index. #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Pushpendra-Garg
wants to merge
1
commit into
main
Choose a base branch
from
vecindex_sync
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| # ----------------------------------------------------------------------------- | ||
| # Copyright (c) 2025, Oracle and/or its affiliates. | ||
| # | ||
| # Licensed under the Universal Permissive License v 1.0 as shown at | ||
| # http://oss.oracle.com/licenses/upl. | ||
| # ----------------------------------------------------------------------------- | ||
|
|
||
| import os | ||
|
|
||
| import pytest | ||
| import select_ai | ||
|
|
||
|
|
||
| def get_credential_env_value(name, default_value=None): | ||
| return os.environ.get(f"PYSAI_TEST_{name}", default_value) | ||
|
|
||
|
|
||
| @pytest.fixture(scope="session") | ||
| def oci_credential(): | ||
| """ | ||
| Override the root autouse OCI credential fixture for credential-only tests. | ||
| These suites should not require OCI environment variables unless a test | ||
| explicitly opts into them. | ||
| """ | ||
| return None | ||
|
|
||
|
|
||
| @pytest.fixture(scope="session") | ||
| def credential_test_params(test_env): | ||
| return { | ||
| "user": test_env.test_user, | ||
| "password": test_env.test_user_password, | ||
| "dsn": test_env.connect_string, | ||
| "user_ocid": get_credential_env_value( | ||
| "OCI_USER_OCID", default_value="user ocid" | ||
| ), | ||
| "tenancy_ocid": get_credential_env_value( | ||
| "OCI_TENANCY_OCID", default_value="tenancy ocid" | ||
| ), | ||
| "private_key": get_credential_env_value( | ||
| "OCI_PRIVATE_KEY", default_value="private key" | ||
| ), | ||
| "fingerprint": get_credential_env_value( | ||
| "OCI_FINGERPRINT", default_value="fingerprint" | ||
| ), | ||
| "cred_username": get_credential_env_value( | ||
| "CRED_USERNAME", default_value="OCI credential username" | ||
| ), | ||
| "cred_password": get_credential_env_value( | ||
| "CRED_PASSWORD", default_value="OCI credential password" | ||
| ), | ||
| } | ||
|
|
||
|
|
||
| @pytest.fixture(scope="session") | ||
| def credential_connect_as(test_env): | ||
| def _connect_as(admin=False, **overrides): | ||
| select_ai.disconnect() | ||
| connect_params = test_env.connect_params(admin=admin) | ||
| connect_params.update(overrides) | ||
| select_ai.connect(**connect_params) | ||
|
|
||
| return _connect_as | ||
|
|
||
|
|
||
| @pytest.fixture(scope="session") | ||
| def credential_async_connect_as(test_env): | ||
| async def _connect_as(admin=False, **overrides): | ||
| await select_ai.async_disconnect() | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We already have async connect and disconnect here No need to connect here |
||
| connect_params = test_env.connect_params(admin=admin) | ||
| connect_params.update(overrides) | ||
| await select_ai.async_connect(**connect_params) | ||
|
|
||
| return _connect_as | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't run select_ai.disconnect() in individual conftest.
We have seen this causes issues as it modifies the global connection state. We already have connect/disconnect in the root level conftest.py which is automatically run for every module.
https://github.com/oracle/python-select-ai/blob/main/tests/conftest.py#L201
We should not do any connection management in individual test suites.