Skip to content

Retire the automated review loop - #818

Merged
Neonforge98 merged 7 commits into
developfrom
refactor/retire-review-loop
Aug 18, 2026
Merged

Retire the automated review loop#818
Neonforge98 merged 7 commits into
developfrom
refactor/retire-review-loop

Conversation

@Neonforge98

@Neonforge98 Neonforge98 commented Aug 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

Retires the orchestrator's automated review loop end to end, per the decision that the durable run pipeline's in_review status projection is the review model going forward. Stacked on the dead-command removal PR.

Backend

  • on_session_complete now always transitions to Completed — no more automatic review phase; on_review_complete / on_review_failed are deleted and TransitionResult shrinks to RetryAgent | Completed | Failed | Ignored (auto-retry on failure is kept)
  • The session-terminal loop no longer launches review/fix sessions, no longer extracts structured review feedback, and no longer writes awaiting-user inbox notifications; launch_phase_session is retry-only
  • orchestrator_cancel / orchestrator_retry / orchestrator_get_status / orchestrator_create_follow_up commands are removed along with the follow_up and branch_health modules — their only consumers were the review panel actions and the stale-phase watchdog, both retired here
  • OrchestratorPhase::Review / AwaitingUser enum variants and stored review_feedback stay for legacy data deserialization; the durable pipeline keeps writing current_phase through its own start path

Frontend

  • useWorkItemOrchestrator (with useAutoReview, useStaleSessionDetection, the collab-lock module, and ownership helpers) is deleted; the two read-only things the detail surface actually needed — the active session projection and PR-creation repo paths — move to a small derived hook, useWorkItemActiveSession
  • The ReviewFeedbackPanel (Fix and rerun / Accept as-is / Create follow-up / Cancel) and the reviewer config section are removed; ChangedFilesList no longer threads review comments
  • The reviewer property field (properties rail row, dropdown, and handlers) is removed; the orphaned Agent Settings panel that hosted the review/follow-up switches is deleted outright
  • ORCHESTRATOR_COMMAND and its error helper are deleted

Failed-run retry remains available through the linked-session row action, which drives the durable run pipeline.

  • The review-loop locale keys (agent settings switches, review feedback panel strings, reviewer picker) are removed from all 13 locales

Verification

  • cargo test -p project_management orchestrator suites: 44 tests passing (review-transition tests rewritten to assert unconditional completion); cargo check clean on agent_core and the app crate
  • npm run typecheck clean; vitest on the Work Items module: 40 files / 201 tests passing; workspace clippy clean
  • Live-tested on a dev build: work item detail renders without the reviewer row; a discussion comment enqueued a durable run that resumed the linked session, posted its receipt, and completed on the first attempt — the session terminal path produced no review session, no awaiting-user state, and the item was projected to In Review by the run pipeline as designed

@Neonforge98
Neonforge98 changed the base branch from refactor/orchestrator-dead-commands to develop August 18, 2026 00:03
Pre-commit hook ran. Total eslint: 0, total circular: 0
Pre-commit hook ran. Total eslint: 0, total circular: 0
Pre-commit hook ran. Total eslint: 0, total circular: 0
Pre-commit hook ran. Total eslint: 4, total circular: 0
Pre-commit hook ran. Total eslint: 4, total circular: 0
Pre-commit hook ran. Total eslint: 4, total circular: 0
@Neonforge98
Neonforge98 force-pushed the refactor/retire-review-loop branch from 04923ef to 26e8f0e Compare August 18, 2026 00:06
Pre-commit hook ran. Total eslint: 0, total circular: 0
@Neonforge98
Neonforge98 merged commit c16b966 into develop Aug 18, 2026
3 checks passed
@Neonforge98
Neonforge98 deleted the refactor/retire-review-loop branch August 18, 2026 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant