Retire the automated review loop - #818
Merged
Merged
Conversation
Neonforge98
changed the base branch from
refactor/orchestrator-dead-commands
to
develop
August 18, 2026 00:03
Pre-commit hook ran. Total eslint: 0, total circular: 0
Pre-commit hook ran. Total eslint: 0, total circular: 0
Pre-commit hook ran. Total eslint: 0, total circular: 0
Pre-commit hook ran. Total eslint: 4, total circular: 0
Pre-commit hook ran. Total eslint: 4, total circular: 0
Pre-commit hook ran. Total eslint: 4, total circular: 0
Neonforge98
force-pushed
the
refactor/retire-review-loop
branch
from
August 18, 2026 00:06
04923ef to
26e8f0e
Compare
Pre-commit hook ran. Total eslint: 0, total circular: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retires the orchestrator's automated review loop end to end, per the decision that the durable run pipeline's
in_reviewstatus projection is the review model going forward. Stacked on the dead-command removal PR.Backend
on_session_completenow always transitions toCompleted— no more automatic review phase;on_review_complete/on_review_failedare deleted andTransitionResultshrinks toRetryAgent | Completed | Failed | Ignored(auto-retry on failure is kept)launch_phase_sessionis retry-onlyorchestrator_cancel/orchestrator_retry/orchestrator_get_status/orchestrator_create_follow_upcommands are removed along with thefollow_upandbranch_healthmodules — their only consumers were the review panel actions and the stale-phase watchdog, both retired hereOrchestratorPhase::Review/AwaitingUserenum variants and storedreview_feedbackstay for legacy data deserialization; the durable pipeline keeps writingcurrent_phasethrough its own start pathFrontend
useWorkItemOrchestrator(withuseAutoReview,useStaleSessionDetection, the collab-lock module, and ownership helpers) is deleted; the two read-only things the detail surface actually needed — the active session projection and PR-creation repo paths — move to a small derived hook,useWorkItemActiveSessionORCHESTRATOR_COMMANDand its error helper are deletedFailed-run retry remains available through the linked-session row action, which drives the durable run pipeline.
Verification
cargo test -p project_managementorchestrator suites: 44 tests passing (review-transition tests rewritten to assert unconditional completion);cargo checkclean onagent_coreand the app cratenpm run typecheckclean;viteston the Work Items module: 40 files / 201 tests passing; workspace clippy clean