fix: clear read count when burn after read is checked#118
Merged
dillonstreator merged 1 commit intoosbytes:mainfrom Apr 27, 2026
Merged
Conversation
When the burn after read checkbox is checked, the read count input is now cleared to undefined. This matches the existing inverse behavior where setting a read count unchecks burn after read, since these options are mutually exclusive. Closes osbytes#103
adavila0703
added a commit
to adavila0703/crypt.fyi
that referenced
this pull request
Apr 30, 2026
Introduces new command-line options for webhook integration during the encryption process. Users can now specify a webhook URL, name, and toggle notifications for various events such as successful reads, failed decryption, and burns. Updated README to include usage examples and detailed descriptions of the new options. Closes osbytes#118
dillonstreator
pushed a commit
that referenced
this pull request
May 1, 2026
* feat: add webhook options for encryption in CLI Introduces new command-line options for webhook integration during the encryption process. Users can now specify a webhook URL, name, and toggle notifications for various events such as successful reads, failed decryption, and burns. Updated README to include usage examples and detailed descriptions of the new options. Closes #118 * refactor(cli): collapse webhook flags into --wh-events list and validate via schema Reworks the CLI webhook interface based on PR review feedback: - Replace 5 per-event boolean flags with single --wh-events comma-separated list - Use vaultValueSchema from @crypt.fyi/core for validation instead of manual checks - Add parseWhEvents and trimmedWhName helpers in new webhook.ts module - Add jest + ts-jest and unit tests for webhook event parsing - Update README with new --wh-url, --wh-events, --wh-name usage examples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
undefinedCloses #103
Test plan