feat(bookings): add date editing with availability validation#239
Open
AlejandroLopez-Dev wants to merge 3 commits intooscarchapp:mainfrom
Open
feat(bookings): add date editing with availability validation#239AlejandroLopez-Dev wants to merge 3 commits intooscarchapp:mainfrom
AlejandroLopez-Dev wants to merge 3 commits intooscarchapp:mainfrom
Conversation
- RoomsView accepts GET param 'q' and applies icontains filter - Template includes search form with clear button and result count - 12 unit tests covering edge cases (empty, whitespace, partial match, case-insensitivity, ordering, context preservation)
- Calculate occupancy as (active NEW bookings / total rooms) * 100 - Guard division by zero when no rooms exist - Replace hardcoded 'DEL' strings with Booking.DELETED constant - Move datetime imports to module level - Reuse bookings_today queryset to reduce redundant DB calls - 6 unit tests: correct calc, cancelled excluded, zero rooms, 100% full
- New BookingDatesForm with clean() validating: order, max date, overlap - Overlap uses standard hotel formula (checkin__lt / checkout__gt) - Cancelled bookings and the booking itself are excluded from conflict check - EditBookingDatesView: GET pre-fills form, POST saves + recalculates total - 13 integration tests: success, self-edit, partial overlaps, cancelled, date constraints
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows editing check-in/check-out dates on an existing booking with
real-time availability validation.
Validation logic
(the booking being edited is excluded from the conflict check)
Changes
Tests
31/31 passing (+13 new integration tests)