Handle boundary edge components and refactor iter_dem_instructions_include_correlations#171
Merged
oscarhiggott merged 10 commits intomasterfrom Sep 25, 2025
Conversation
…t rewrites in the search graph weren't always undone.
… component in a decomposed error with more than one component
Merged
…#176) Co-authored-by: oscarhiggott <29460323+oscarhiggott@users.noreply.github.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #171 +/- ##
==========================================
- Coverage 99.15% 99.14% -0.01%
==========================================
Files 3 3
Lines 353 351 -2
==========================================
- Hits 350 348 -2
Misses 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where boundary edges weren't always handled properly when they were a component of an error. i.e.
handle_dem_errorwas called the same on edges and boundary edges:This resulted in an exception if the boundary edge was not already in the graph. Also refactors related logic slightly.