refactor: [DC-310] final cleanup after main window reorg#12558
Open
modSpike wants to merge 29 commits into
Open
refactor: [DC-310] final cleanup after main window reorg#12558modSpike wants to merge 29 commits into
modSpike wants to merge 29 commits into
Conversation
the basics are done here, and the account view still works in the new gui after the changes.
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
deleting the class to come
get it from master once merged.
these have been replaced with MainWindow, SettngsView and AboutView (all in subfolder mainwindow)
fixed missing folder wizard after create account with selective sync refactored the manage account menu actions renamed a few things
with most changes in the updatedownloadedwidget which has been converted to QDialog it basically was a QDialog but with the button signals/slots hand coded instead of just using the base dialog impl. needs testing on platform that actually supports the updater impl
also removed the very strange impls related to clicking the tray menu icon
mostly to get non-tray related stuff out of owncloudgui, but also to "request" functionality that lives primarily in main window controller
the point is: if you can get MainWindow you can call all the public interfaces of MainWindow, which would include things like addViewAction and other stuff that should not be called "by just anyone". Replace the truly necessary public interface with wrappers in Application and only return QMainWindow * from Application::mainWindow()
it does what it says on the tin!
also removed a bunch of dead includes here and ther
just amended a comment and removed some whitespace
overzealous cleanup of application removed key connection that queued folders loaded from config squis tests should now pass
also added object name to manage account menu
Contributor
Author
|
@erikjv please do the updater checks as part of your review! |
Signed-off-by: Prajwol Amatya <prajwolamatya11@gmail.com>
erikjv
approved these changes
Jun 30, 2026
erikjv
left a comment
erikjv
left a comment
Contributor
There was a problem hiding this comment.
Still needs testing of the update UI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see https://kiteworks.atlassian.net/browse/DC-310