MM: fix(photo-addon): use 24-hour time format in lightbox#342
Merged
Conversation
mmattel
force-pushed
the
mm-feat-photo-addon-24h-time
branch
from
5cfba80 to
fe9b3ad
Compare
LukasHirt
reviewed
Mar 9, 2026
| hour: '2-digit', | ||
| minute: '2-digit' | ||
| minute: '2-digit', | ||
| hour12: false |
Collaborator
There was a problem hiding this comment.
Shouldn't this be dynamic depending on the selected locale? What if user uses locale that uses 12 hour format?
Collaborator
There was a problem hiding this comment.
Just to make this clear: by selected locale I mean the locale selected within oCIS in the accounts page and not the os/browser locale.
mmattel
force-pushed
the
mm-feat-photo-addon-24h-time
branch
2 times, most recently
from
1fce209 to
6ed95fd
Compare
paul43210
added a commit
to paul43210/web-extensions
that referenced
this pull request
Mar 16, 2026
Remove hardcoded hour12: false from formatExifDate — the oCIS user locale already determines the appropriate time format (e.g., en-US uses 12h, de uses 24h). Addresses Lukas's review on owncloud#342. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Use hour12: false in toLocaleDateString() so the "Date Taken" field in the lightbox shows 14:30 instead of 2:30 PM. AM/PM notation is US-centric and confusing for international users. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Several date formatting calls in PhotosView and usePhotos were using browser default locale (undefined) instead of the oCIS user's preferred language. Now consistently uses getUserLocale() from useTranslations for timeline group labels (week ranges, month names, full dates). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove hardcoded hour12: false from formatExifDate — the oCIS user locale already determines the appropriate time format (e.g., en-US uses 12h, de uses 24h). Addresses Lukas's review on #342. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mmattel
force-pushed
the
mm-feat-photo-addon-24h-time
branch
from
e3df511 to
b0b021f
Compare
toLocaleDateString handles time options (hour, minute) inconsistently across browsers — in EN locale it showed "13:56 PM" instead of "1:56 PM". Switch to toLocaleString which correctly handles both date and time formatting per the oCIS user locale. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Use hour12: false in toLocaleDateString() so the "Date Taken" field in the lightbox shows 14:30 instead of 2:30 PM. AM/PM notation is US-centric and confusing for international users. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Several date formatting calls in PhotosView and usePhotos were using browser default locale (undefined) instead of the oCIS user's preferred language. Now consistently uses getUserLocale() from useTranslations for timeline group labels (week ranges, month names, full dates). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove hardcoded hour12: false from formatExifDate — the oCIS user locale already determines the appropriate time format (e.g., en-US uses 12h, de uses 24h). Addresses Lukas's review on #342. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
toLocaleDateString handles time options (hour, minute) inconsistently across browsers — in EN locale it showed "13:56 PM" instead of "1:56 PM". Switch to toLocaleString which correctly handles both date and time formatting per the oCIS user locale. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mmattel
force-pushed
the
mm-feat-photo-addon-24h-time
branch
from
b0b021f to
38e5c76
Compare
The tooltip previously implied the filter checked for any EXIF metadata (camera, model, location, etc.), but it actually filters by EXIF date (takenDateTime). Updated tooltip to accurately describe the behavior and explain that EXIF date is required for timeline placement, just as EXIF location is required for map view. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
LukasHirt
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References: #341 (fix(photo-addon): use 24-hour time format in lightbox)
This is the CI working version of the referenced PR (based on my request via Matrix).
@LukasHirt tested locally and works well