Skip to content

Conversation

@charliepark
Copy link
Contributor

@charliepark charliepark commented Feb 3, 2026

https://console-git-removetabletitle-oxidecomputer.vercel.app/projects/mock-project/vpcs/mock-vpc/routers/mock-system-router
https://console-git-removetabletitle-oxidecomputer.vercel.app/projects/mock-project/affinity/romulus-remus

This removes an irregular title from the page, and adds a divider line to separate the properties table at the top from the routes table below. It was the last use of the TableControls component, so I removed that as well. TableTitle still has one remaining use, on the Settings page to list Groups.

Screenshot 2026-02-02 at 4 48 51 PM

Ben, would love your eyes on that mt-6 and whether it's the right gap. On pages with tabs we have a 10 level of margin, but that was looking awfully big on the left side of the screen.

Closes #3022

@vercel
Copy link

vercel bot commented Feb 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
console Ready Ready Preview Feb 3, 2026 5:40pm

Request Review

@david-crespo
Copy link
Collaborator

Was surprised to find this page is basically unique in having a properties table but no tabs.

@benjaminleonard
Copy link
Contributor

Set to my-10 to match the others. If it feels too big we should reduce it everywhere, but this should be consistent with the tab bar spacing.

@benjaminleonard
Copy link
Contributor

Was surprised to find this page is basically unique in having a properties table but no tabs.

Affinity group page also. That wraps the table in a settings group, which we could potentially do here if you'd prefer the clarity.

I've also reduced the spacing across the board to my-8 on both divider and tab bars. Don't say I never treat ya!

@david-crespo
Copy link
Collaborator

Spacing looks good. I do think I prefer the card block treatment on affinity groups. I'd also cut the space around the divider there to my-8, what do you think?

image

@charliepark
Copy link
Contributor Author

Yeah, I like the card block layout as well.

@charliepark
Copy link
Contributor Author

Screenshot 2026-02-03 at 9 35 38 AM

@david-crespo david-crespo changed the title Remove irregular table title from router page Put routes table on router page in card block Feb 3, 2026
Copy link
Collaborator

@david-crespo david-crespo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

INTO IT

@david-crespo david-crespo merged commit 61464d9 into main Feb 3, 2026
7 checks passed
@david-crespo david-crespo deleted the remove_table_title branch February 3, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove "routes" table title

4 participants