-
Notifications
You must be signed in to change notification settings - Fork 21
Put routes table on router page in card block #3024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Was surprised to find this page is basically unique in having a properties table but no tabs. |
|
Set to |
Affinity group page also. That wraps the table in a settings group, which we could potentially do here if you'd prefer the clarity. I've also reduced the spacing across the board to |
|
Yeah, I like the card block layout as well. |
david-crespo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
INTO IT


https://console-git-removetabletitle-oxidecomputer.vercel.app/projects/mock-project/vpcs/mock-vpc/routers/mock-system-router
https://console-git-removetabletitle-oxidecomputer.vercel.app/projects/mock-project/affinity/romulus-remus
This removes an irregular title from the page, and adds a divider line to separate the properties table at the top from the routes table below. It was the last use of the
TableControlscomponent, so I removed that as well.TableTitlestill has one remaining use, on the Settings page to listGroups.Ben, would love your eyes on that
mt-6and whether it's the right gap. On pages with tabs we have a10level of margin, but that was looking awfully big on the left side of the screen.Closes #3022